Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch master branch bazel to kubekins and enable cache for unit tests #7004

Merged
merged 1 commit into from
Feb 26, 2018
Merged

switch master branch bazel to kubekins and enable cache for unit tests #7004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions prow/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,9 +891,10 @@ presubmits:
- release-1.9 # need to cherry pick back https://github.com/kubernetes/kubernetes/pull/59251, possibly others
labels:
preset-service-account: true
preset-bazel-scratch-dir: true
spec:
containers:
- image: gcr.io/k8s-testimages/bazelbuild:v20180201-0184a54dc-0.10.0
- image: gcr.io/k8s-testimages/kubekins-e2e:v20180223-74690e8dc-master
args:
- "--clean"
- "--git-cache=/root/.cache/git"
Expand All @@ -904,12 +905,10 @@ presubmits:
- "--" # end bootstrap args, scenario args below
- "--build=//... -//vendor/..."
- "--release=//build/release-tars"
env:
- name: TEST_TMPDIR
value: /root/.cache/bazel
# Bazel needs privileged mode in order to sandbox builds.
securityContext:
privileged: true
# TODO(bentheelder): eliminate the "git caching" junk
volumeMounts:
- name: cache-ssd
mountPath: /root/.cache
Expand Down Expand Up @@ -1169,9 +1168,10 @@ presubmits:
- release-1.9 # need to cherry pick back https://github.com/kubernetes/kubernetes/pull/59251, possibly others
labels:
preset-service-account: true
preset-bazel-scratch-dir: true
spec:
containers:
- image: gcr.io/k8s-testimages/bazelbuild:v20180201-0184a54dc-0.10.0
- image: gcr.io/k8s-testimages/kubekins-e2e:v20180223-74690e8dc-master
args:
- "--clean"
- "--git-cache=/root/.cache/git"
Expand All @@ -1187,11 +1187,12 @@ presubmits:
- "--test-args=--test_tag_filters=-e2e,-integration"
- "--test-args=--flaky_test_attempts=3"
env:
- name: TEST_TMPDIR
value: /root/.cache/bazel
- name: BAZEL_REMOTE_CACHE_ENABLED
value: "true"
# Bazel needs privileged mode in order to sandbox builds.
securityContext:
privileged: true
# TODO(bentheelder): eliminate the "git caching" junk
volumeMounts:
- name: cache-ssd
mountPath: /root/.cache
Expand Down Expand Up @@ -2762,6 +2763,7 @@ presubmits:
cluster: security
context: pull-security-kubernetes-bazel-build
labels:
preset-bazel-scratch-dir: "true"
preset-service-account: "true"
max_concurrency: 0
name: pull-security-kubernetes-bazel-build
Expand Down Expand Up @@ -2830,7 +2832,7 @@ presubmits:
- --release=//build/release-tars
- --gcs=gs://kubernetes-security-prow/ci/pull-security-kubernetes-bazel-build
- --gcs-shared=gs://kubernetes-security-prow/bazel
image: gcr.io/k8s-testimages/bazelbuild:v20180201-0184a54dc-0.10.0
image: gcr.io/k8s-testimages/kubekins-e2e:v20180223-74690e8dc-master
name: ""
resources:
requests:
Expand Down Expand Up @@ -3068,6 +3070,7 @@ presubmits:
cluster: security
context: pull-security-kubernetes-bazel-test
labels:
preset-bazel-scratch-dir: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are some of these true and some of these "true"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the security repo is auto generated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of our hand written stuff is overly quoted, the security repo has fully auto generated config so it gets whatever quoting is left after being shoved through go's yaml and a python lib.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shrug

preset-service-account: "true"
max_concurrency: 0
name: pull-security-kubernetes-bazel-test
Expand Down Expand Up @@ -3095,7 +3098,10 @@ presubmits:
- --test-args=--build_tag_filters=-e2e,-integration
- --test-args=--test_tag_filters=-e2e,-integration
- --test-args=--flaky_test_attempts=3
image: gcr.io/k8s-testimages/bazelbuild:v20180201-0184a54dc-0.10.0
env:
- name: BAZEL_REMOTE_CACHE_ENABLED
value: "true"
image: gcr.io/k8s-testimages/kubekins-e2e:v20180223-74690e8dc-master
name: ""
resources:
requests:
Expand Down