-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize processes for regularly upgrading website tools #37187
Comments
/priority important-longterm |
Thanks for filing this. |
Heres a list of tools i found that should be things we should track to update regularly.
Also included in the netlify.toml file:
Based on looking at the history of the netlify.toml file, we update the Hugo version about 2 times a year. Based on the Docsy theme folder history, we have updated Docsy about 3 times a year, but this year have only updated it once in April. For both Hugo and Docsy, this feels like a good cadence, to try and update them about 2 times a year and in the event of a security update. We added the Ruby version to avoid netilfy builds slow-downs, #22229, but its not clear to me how we use Ruby. Similarly the node version was added to avoid build errors, #20963, but it's not clear to me why we need it. Based on looking at the file history, we have update the ruby version once since it was added in 2020, and we have never updated the node version since it was added in 2020. @sftim or @tengqm can you shed some like as to why we need Ruby or Node, and how frequently we should be updating them? |
TBH, I have no idea why we need NodeJS or Ruby. |
We could allow Netlify to use whatever version of Ruby and NodeJS it wants to provide. https://www.docsy.dev/docs/get-started/docsy-as-module/installation-prerequisites/#installupgrade-nodejs explains that Node.js is required by Hugo (as a prerequisite for Docsy to work properly). I don't think Ruby gets used anywhere. |
Maybe we can start by comment out the |
I created a PR with the Ruby version commented out, #39114 . The build appeared to be fine, and used the default ruby version 2.7.0. I found a list of the default things installed in our build image, https://docs.netlify.com/configure-builds/available-software-at-build-time/#app The defaults are an older version of Ruby, 2.7.0, and newer version of node.js, 16. |
What needs to happen next on this? |
/lifecycle frozen |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/triage accepted |
This is a Feature Request
Currently there isn't a process or automation that covers upgrading the tools we use for the kubernetes.io website. Specifically Hugo and our theme Docsy.
What would you like to be added
We should determine a list of tools we need to keep updated, and then create a way to trigger updating the tools at an interval that makes sense for the project and maintainer bandwidth. Either by some automation or manually upgrading the tools
We should also make sure we have tool upgrade processes documented, especially any differences with the tools upgrade docs. (these could already exist, but i'm not sure where they are located so i included it here :) )
Why is this needed
Previously these kinds of updates were triggered by bugs in the tools. Ideally, we'd also have a way to upgrade when we want to to access new features or improvements.
Comments
Some related links:
The text was updated successfully, but these errors were encountered: