Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating theme submodule #23434

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

jimangel
Copy link
Member

Docsy recently had a security update (ref: google/docsy#330)

This PR should bring the submodule up to date. I wouldn't mind someone checking my git commands:

# after updating local fork, checkout new branch
git checkout -b docsy-patch

# update my local fork to contain the submodule
git submodule update --init --recursive --depth 1

# update submodule to the latest remote hash
git submodule update --remote

# add the folder for tracking (ignoring the untracked files)
git add themes/

# commit and push
git commit -m "updating theme submodule"
git push origin docsy-patch

https://www.docsy.dev/docs/updating/

/cc @sftim @zacharysarah @kbhawkey @kbarnard10 @onlydole

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2020
@netlify
Copy link

netlify bot commented Aug 25, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4bb6d47

https://deploy-preview-23434--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

Hello @jimangel .
The commands seem right. I assume this updates the commit on the site's themes/docsy folder (hence the one file change)?

@jimangel
Copy link
Member Author

I assume this updates the commit on the site's themes/docsy folder (hence the one file change)?

Yep! It's easier to see on my fork / branch: https://github.com/jimangel/website/tree/docsy-patch/themes vs https://github.com/kubernetes/website/tree/master/themes

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit f0d37cd into kubernetes:master Sep 1, 2020
@jimangel jimangel mentioned this pull request Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants