Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating docsy theme submodule #24573

Merged
merged 1 commit into from
Oct 16, 2020
Merged

updating docsy theme submodule #24573

merged 1 commit into from
Oct 16, 2020

Conversation

kbhawkey
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2020
@kbhawkey kbhawkey changed the title updating docsy theme submodule [wip]updating docsy theme submodule Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 14, 2020
@netlify
Copy link

netlify bot commented Oct 14, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 27afc0b

https://deploy-preview-24573--kubernetes-io-master-staging.netlify.app

@kbhawkey kbhawkey changed the title [wip]updating docsy theme submodule updating docsy theme submodule Oct 15, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2020
@kbhawkey
Copy link
Contributor Author

/cc @jimangel

@sftim
Copy link
Contributor

sftim commented Oct 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ff3c06eee395ee6d49a1cb784d97f17e6585d35e

irvifa
irvifa reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit a0e75c3 into kubernetes:master Oct 16, 2020
@kbhawkey kbhawkey deleted the docsy-update-submodule-10-14-20 branch October 27, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@onlydole onlydole Awaiting requested review from onlydole

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbhawkey @sftim @k8s-ci-robot @irvifa