Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating docsy theme submodule #26814

Merged
merged 1 commit into from
Mar 6, 2021
Merged

updating docsy theme submodule #26814

merged 1 commit into from
Mar 6, 2021

Conversation

Colstuwjx
Copy link
Contributor

This PR is going to update docsy theme version to the latest ( a7dc774 ), the instructions followed PR #23434 comment.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2021
@Colstuwjx
Copy link
Contributor Author

Colstuwjx commented Mar 3, 2021 •
edited
Loading

Ping @sftim @jimangel @kbhawkey , this PR is mainly in order to introduce docsy print feature, and I'll take another PR to introduce the config change after this PR get merged. The related context see #26808 , #26809 .

@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fa2057b

https://deploy-preview-26814--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Mar 3, 2021

/area web-development
LGTM

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Mar 3, 2021
@Colstuwjx
Copy link
Contributor Author

Ping @kbhawkey @jimangel , could you please help me review this PR?

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 6, 2021

👀

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 6, 2021

Hi @Colstuwjx .
The updates look fine. The theme was updated in October.
The "print" configuration will introduce a number of changes to the site layout.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4cc3d7f1230185a7a96f9d5a60dc874a492047ac

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 6, 2021

The site builds with this update:
https://deploy-preview-26814--kubernetes-io-master-staging.netlify.app/
https://deploy-preview-26814--kubernetes-io-master-staging.netlify.app/blog/
https://deploy-preview-26814--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/pods/

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 96b4a51 into kubernetes:master Mar 6, 2021
@Colstuwjx Colstuwjx deleted the docsy-version-update branch March 7, 2021 00:53
@Colstuwjx
Copy link
Contributor Author

image

After this PR get merged, the netlify status icon turns to "failed" :(
I'm not sure what's the root cause, netlify link: this.

@Colstuwjx
Copy link
Contributor Author

My mistake, it seems that it's staging build status 😅

@Colstuwjx Colstuwjx mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Colstuwjx @sftim @kbhawkey @k8s-ci-robot