Specify a node version in netlify.toml #20963
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
zacharysarah
force-pushed
the
specify-node-version
branch
3 times, most recently
from
09de064 to
7263d05
Compare
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 09de064 https://deploy-preview-20963--kubernetes-io-master-staging.netlify.app |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d656fd1 https://deploy-preview-20963--kubernetes-io-master-staging.netlify.app |
zacharysarah
force-pushed
the
specify-node-version
branch
5 times, most recently
from
88de68e to
bc53c4c
Compare
zacharysarah
changed the title
zacharysarah
force-pushed
the
specify-node-version
branch
from
bc53c4c to
d656fd1
Compare
|
/lgtm (for what it's worth) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
| @@ -8,6 +8,7 @@ command = "make non-production-build" | |||
|
|
|||
| [build.environment] | |||
| HUGO_VERSION = "0.70.0" | |||
| NODE_VERSION = "10.20.0" | |||
There was a problem hiding this comment.
@zacharysarah why not use the latest LTS version (== 12.16.3) ?
This PR attempts to address the Node version error we see when trying to build a preview for #20874.
I'm taking this approach based on this conversation in Netlify docs, with formatting from npm docs.
This is my first time adding an
engines:block, so who knows if I'm doing it right. 🤷UPDATE: Netlify ignored the version set in
package.json, so I specified aNODE_VERSIONinnetlify.tomlinstead, which works fine, but does highlight a whole bunch of build-related errors that show we don't really know where our environments are specified.