Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glossary tooltips to Virtual IPs and Service Proxies #38166

Closed
sftim opened this issue Nov 29, 2022 · 5 comments
Closed

Add glossary tooltips to Virtual IPs and Service Proxies #38166

sftim opened this issue Nov 29, 2022 · 5 comments
Assignees
@vaibhav2107
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Nov 29, 2022

This is a Bug Report

Problem:
Update Virtual IPs and Service Proxies: find terms that have glossary entries, and for the first mention of each term, change that to a glossary tooltip.

Proposed Solution:

Page to Update:
https://kubernetes.io/docs/reference/networking/virtual-ips/

Additional Information:
See https://kubernetes.io/docs/contribute/style/hugo-shortcodes/#glossary for more details.

Mentioned in #36675 (comment)

/language en
@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2022
@vaibhav2107
Copy link
Member

/assign

@sftim
Copy link
Contributor Author

sftim commented Nov 29, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2022
@vaibhav2107 vaibhav2107 mentioned this issue Feb 6, 2023
Merged
@vaibhav2107
Copy link
Member

The PR #39307 that fixes this issue has been merged, the issue can be closed now

@sftim
Copy link
Contributor Author

sftim commented Feb 8, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibhav2107 vaibhav2107

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k8s-ci-robot @sftim @vaibhav2107