Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the glossary tooltips to Virtual IPs and Service Proxies #39307

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

vaibhav2107
Copy link
Member

Ref: #38166

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 6, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

One important tweak (about events)

Deployment, then with `minSyncPeriod: 0s`, kube-proxy would end up
removing the Service's Endpoints from the iptables rules one by one,
for a total of 100 updates. With a larger `minSyncPeriod`, multiple
Pod deletion events would get aggregated together, so kube-proxy might
Pod deletion {{< glossary_tooltip term_id="event" text="events" >}} would get aggregated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pod deletion {{< glossary_tooltip term_id="event" text="events" >}} would get aggregated
Pod deletion events would get aggregated

we're not talking about the Event API here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sftim for the info, will update the change

content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
@vaibhav2107
Copy link
Member Author

PTAL @sftim

@netlify
Copy link

netlify bot commented Feb 7, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 058dadb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63e19398902fe70009aa3664
😎 Deploy Preview https://deploy-preview-39307--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d3c9a6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63e196fb20dc970008088110
😎 Deploy Preview https://deploy-preview-39307--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vaibhav2107
Copy link
Member Author

Hi @nate-double-u @shannonxtreme
Could you please have a look

@shannonxtreme
Copy link
Contributor

@vaibhav2107 when reviewers get assigned to an issue or PR they get notified through GitHub so you don't have to ping them. Since most are volunteers reviews might take longer than you expect 🙂

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 96f33babae38a7bdc2c9b21b3aff385cab6fece7

@vaibhav2107
Copy link
Member Author

Sure @shannonxtreme, will keep in mind

@reylejano
Copy link
Member

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 16614c0 into kubernetes:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants