-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the glossary tooltips to Virtual IPs and Service Proxies #39307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
One important tweak (about events)
Deployment, then with `minSyncPeriod: 0s`, kube-proxy would end up | ||
removing the Service's Endpoints from the iptables rules one by one, | ||
for a total of 100 updates. With a larger `minSyncPeriod`, multiple | ||
Pod deletion events would get aggregated together, so kube-proxy might | ||
Pod deletion {{< glossary_tooltip term_id="event" text="events" >}} would get aggregated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pod deletion {{< glossary_tooltip term_id="event" text="events" >}} would get aggregated | |
Pod deletion events would get aggregated |
we're not talking about the Event API here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sftim for the info, will update the change
PTAL @sftim |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @nate-double-u @shannonxtreme |
@vaibhav2107 when reviewers get assigned to an issue or PR they get notified through GitHub so you don't have to ping them. Since most are volunteers reviews might take longer than you expect 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 96f33babae38a7bdc2c9b21b3aff385cab6fece7
|
Sure @shannonxtreme, will keep in mind |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: #38166