kubeadm: update API types documentation for 1.12 #10283

neolit123 · 2018-09-13T01:38:27Z

v1alpha2 -> v1alpha3
MasterConfiguration -> [new-api-types]

tech-review:
/assign @timothysc @fabriziopandini

docs review:
/assign @Bradamant3

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

k8sio-netlify-preview-bot · 2018-09-13T01:38:29Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit f0d1f27

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b99bf934ed62f7a7d7536dd

k8sio-netlify-preview-bot · 2018-09-13T01:44:06Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 34ffad7

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b9fbf103813f01e760eb378

xiangpengzhao

Just two nits, otherwise LGTM.

xiangpengzhao · 2018-09-13T04:25:03Z

content/en/docs/setup/independent/kubelet-integration.md

+see all the default values for this structure.
+
+Also have a look at the [API reference for the
+kubelet ComponentConfig](https://godoc.org/k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig#KubeletConfiguration)


This link is Not Found :(

looks like it was changed to: https://godoc.org/k8s.io/kubernetes/pkg/kubelet/apis/config#KubeletConfiguration
will update.

xiangpengzhao · 2018-09-13T04:30:42Z

content/en/docs/setup/independent/troubleshooting-kubeadm.md

@@ -190,7 +190,7 @@ Error from server: Get https://10.19.0.41:10250/containerLogs/default/mysql-ddc6
  curl http://169.254.169.254/metadata/v1/interfaces/public/0/anchor_ipv4/address
  ```

-  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [KubeletExtraArgs section of the MasterConfiguration file](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha2/types.go#L147) can be used for this.
+  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [`KubeletExtraArgs` section of the kubeadm `NodeRegistrationOptions` structure](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha3/types.go#L163-L166) can be used for this.



It be good to link to the file of related release, in case the file of master branch changes in the future.

zparnold · 2018-09-13T15:20:56Z

/assign @Bradamant3
This one is all you Jen. 😄

timothysc

/lgtm
/approve

zparnold · 2018-09-13T17:41:20Z

/assign @Bradamant3 If you're up for approving. 😄

xiangpengzhao · 2018-09-14T01:53:02Z

content/en/docs/setup/independent/troubleshooting-kubeadm.md

@@ -190,7 +190,7 @@ Error from server: Get https://10.19.0.41:10250/containerLogs/default/mysql-ddc6
  curl http://169.254.169.254/metadata/v1/interfaces/public/0/anchor_ipv4/address
  ```

-  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [KubeletExtraArgs section of the MasterConfiguration file](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha2/types.go#L147) can be used for this.
+  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [`KubeletExtraArgs` section of the kubeadm `NodeRegistrationOptions` structure](https://github.com/kubernetes/kubernetes/blob/19d91db5a8673b8ad2b1b90cb9409529fe8077dd/cmd/kubeadm/app/apis/kubeadm/v1alpha3/types.go#L163-L166) can be used for this.


I'd prefer to using a release branch instead of some commit here :)

ref: https://github.com/kubernetes/website/pull/10056/files#diff-c8c8a85707d5e5dfddc89896ce5fa62cR344

my bad, looks like i rushed reading your previous comment. :)

P.S. rebasing commits against k/website release branches is the opposite of fun.

xiangpengzhao · 2018-09-14T07:42:06Z

content/en/docs/setup/independent/troubleshooting-kubeadm.md

@@ -190,7 +190,7 @@ Error from server: Get https://10.19.0.41:10250/containerLogs/default/mysql-ddc6
  curl http://169.254.169.254/metadata/v1/interfaces/public/0/anchor_ipv4/address
  ```

-  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [KubeletExtraArgs section of the MasterConfiguration file](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha2/types.go#L147) can be used for this.
+  The workaround is to tell `kubelet` which IP to use using `--node-ip`. When using Digital Ocean, it can be the public one (assigned to `eth0`) or the private one (assigned to `eth1`) should you want to use the optional private network. The [`KubeletExtraArgs` section of the kubeadm `NodeRegistrationOptions` structure](https://github.com/kubernetes/kubernetes/blob/release-1.12/cmd/kubeadm/app/apis/kubeadm/v1alpha3/types.go#L163-L166) can be used for this.


What I was thinking of is using {{< param "docsbranch" >}}, but since this change is against 1.12 directly, using release-1.12 LGTM. @zacharysarah WDYT?

yeah, i don't know what {{< param "docsbranch" >}} is.
sorry.

let's leave it hard-coded for now

content/en/docs/reference/setup-tools/kubeadm/implementation-details.md

v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types]

Bradamant3 · 2018-09-19T21:28:23Z

/lgtm per timothysc ^
/approve for docs review

k8s-ci-robot · 2018-09-19T21:28:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Bradamant3 · 2018-09-19T21:29:13Z

o bot

/lgtm

* Update docs for fields allowed at root of CRD schema (#9973) * add plugin docs and examples (#10053) * docs update to promote TaintNodesByCondition to beta (#9626) * HPA Specificity Improvements (#8757) Updated the HPA docs to reference the `autoscaling/v2beta2` API version, and added documentation about the new fields. * adjust docs for pod ready++ (#10049) * Remove --cadvisor-port - has been deprecated since v1.10 (#10023) Change-Id: Id2a685473a243aef492a98ff450759f39e362557 * Add Documentation for Snapshot Feature (#9948) * Add documentation for snapshot feature * Update volume-snapshots.md * Add dry-run to api-concepts (#10033) * kubeadm-init: Update the offline support section (#10062) The update includes the following things (in mind with Kubernetes 1.12): - Remove the 1.8 image versions - Add the 1.10 image versions that were missing until now - Include a comment for the missing arch suffixes in 1.12 Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com> * Say bye to `DynamicProvisioningScheduling` (#10157) The mentioned feature gate is now collapsed into `VolumeScheduling`. xref: kubernetes/kubernetes#67432 * Update ResourceQuota per PriorityClass state for 1.12 (#10229) * TokenRequest and TokenRequestProjection now beta (#10161) xref: kubernetes/kubernetes#67349 * Change feature state for kms provider to beta. (#10230) KMS Provider will be graduating to beta in v1.12, reflecting this change on the website. * coredns default (#10200) * Promote ShareProcessNamespace to beta in docs (#9996) * Add CoreDNS details to DNS Debug docs (#10201) * add coredns details * address nits, add query logging section * Update docs with topology aware dynamic provisioning (#9939) * Document topology aware volume binding feature * update for readability * Update storage-classes.md * comma splice * don't abbreviate * HPA Algorithm Information Improvements (#9780) * Update HPA docs with more algorithm details The HPA docs pointed to an out-of-date document for information on the algorithm details, which users were finding confusing. This sticks a section on the algorithm in the HPA docs instead, documenting both general behavior and corner cases. * Add glossary info, HPA docs on quantities People often ask about the quantity notation when working with the metrics APIs, so this adds a glossary entry on quantities (since they're used elsewhere in the system), and a short explantation in the HPA walkthough. * Information about HPA readiness and stabilization This adds information about the new changes to HPA readiness and stabilization from kubernetes/enhancements#591, and other minor changes that landed in Kubernetes 1.12. * Update horizontal-pod-autoscale.md * Audit 1.12 doc (#9953) * audit 1.12 document * remove legacy audit feature kubernetes/kubernetes#65862 * update feature gate doc * MountPropagation is now GA (#10090) * RuntimeClass documentation (#10102) * RuntimeClass documentation * Update runtime-class.md * Add documentation for Scheduler performance tuning (#10048) * Add documentation for Scheduler performance tuning * Update scheduler-perf-tuning.md * TTL controller for cleaning up finished resources (#10064) * TTL controller for cleaning up finished resources * Address comments * Update ttlafterfinished.md * Bump quota configuration api version (#10217) * Incremental update from master (#10278) * fix invalid href of cloud controller manager (#10240) * fix invalid yaml format (#10238) * update storage-limits doc with Azure disk part (#10224) update storage-limits doc with Azure disk part fix comments * Update kubelet-config-file.md (#10222) Update link to KubeletConfiguration struct. * fix a trivial misspelling (#10244) * Fix cassandra-statefulset.yaml indent level (#10243) * Mention minimum etcd versions (#10208) Source: https://groups.google.com/d/msg/kubernetes-dev/jMPA4JzKiY4/HIx2ugvLBAAJ * fix 404 error (#10250) * Small verb tweak (#10190) Present participle, ftw. * Add AnchorJS logic for header links (#10155) * Add AnchorJS JavaScript * Remove existing inpage_heading logic * Remove underline from anchor tags * Use single icon and add touch visibility * Use paragraph link icon for AnchorJS * Update Sass to use code formatting in docsContent headers * Update header size coverage to H3-H6 * fix broken link in kubefed.md (#10254) * Update the version numbers for the X-Remote-Extra- and Impersonate-Extra- key fixes (#9827) The fix was cherry picked into 1.11.3, 1.10.7, and 1.9.11: kubernetes/kubernetes#67162 kubernetes/kubernetes#67163 kubernetes/kubernetes#67164 * fix typo (#10168) * fix typo * addressing comments. * Update setup-ha-etcd-with-kubeadm.md * fix typos (#10252) * fix description of contribute guide (#10253) * describe truncate feature about advanced audit (#10236) * describe truncate feature about advanced audit * Update audit.md * docs update to promote ScheduleDaemonSetPods to beta (#9923) * Dynamic volume limit updates for 1.12 (#10211) * add a placeholder commit * Update docs for csi volume limits * Update storage-limits.md * Add "MayRunAs" value among other GroupStrategies (#9888) * Add CoreDNS details to the customize DNS doc (#10228) * Add CoreDNS details to the customize DNS doc Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12 * Address comments * Improve doc wording * Fix link * Update dns-custom-nameservers.md * Update dns-custom-nameservers.md * Fix secrets docs in 1.12 branch (#10056) * Fix secrets docs * Update secret.md * Revert CoreDNS Docs (#10319) * Revert "Add CoreDNS details to DNS Debug docs (#10201)" This reverts commit 462817a. * Revert "Add CoreDNS details to the customize DNS doc (#10228)" This reverts commit e7319ee. * Revert "coredns default (#10200)" This reverts commit 698e93b. * Add CRI installation instructions page Added cri-installation page with CRI installation instructions Referenced it from kubeadm-init and install-kubeadm pages. * kubeadm: update API types documentation for 1.12 (#10283) v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types] * TokenRequest feature documentation (#10295) * AdvancedAuditing is now GA (#10156) xref: kubernetes/kubernetes#65862 `AdvancedAuditing` feature is GA in 1.12. This PR adjusts the related docs. * update runtime-class.md (#10332) * update runtime-class.md * Update runtime-class.md * Document cross-authorizer permissions for creating RBAC roles (#10015) * Document cross-authorizer permissions for creating RBAC roles * Update rbac.md * kubeadm: update authored content for 1.12 (reference docs and cluster creation) (#10348) * kubeadm: update authored content in reference docs for 1.12 * kubeadm: add time frame in create-cluster-kubeadm for 1.12 * add AllowedProcMountTypes and ProcMountType to docs (#9911) Signed-off-by: Jess Frazelle <acidburn@microsoft.com> * kubeadm: add new command line reference (#10306) Add: - placeholder files - include place holder files - include "renew" sub command - add missing tabs for "alpha phase kubelet" * Documenting SCTP support in Kubernetes (#10279) * Documenting SCTP support in Kubernetes Service, Endpoint, NetworkPolicy and Pod * Updates based on comments on the PR * kubectl expose update with SCTP support * Updated according to comments in the PR * Revert "kubectl expose update with SCTP support" This reverts commit 0d5a1e6. * TLS Bootstrap and Server Cert Rotation feature documentation (#10232) * TokenRequest feature documentation * line wrapping to make review not insane * update content for GA without major refactor * Update kubelet-tls-bootstrapping.md * Add clarifications for volume snapshots (#10296) * Update kubadm ha installation for 1.12 (#10264) * Update kubadm ha installation for 1.12 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * update stable version Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Update stacked control plane for v1.12 (#2) * use v1alpha3 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * more v1alpha3 (#4) * updates Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Document how to run in-tree cloud providers with kubeadm (#10357) Change-Id: Iab6b996a830503d74a6eb0c507c5f8ca7a39235b * kubeadm reference doc for release 1.12 (#10359) * Revert "Revert "Add CoreDNS details to DNS Debug docs (#10201)"" This reverts commit bb30f4d. * Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)"" This reverts commit bc23d45. * Revert "Revert "coredns default (#10200)"" This reverts commit 7f4350d. * add missing instruction for ha guide (#10374) Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm - Ha upgrade updates (#10340) * Update HA upgrade docs * Adds external etcd HA upgrade guide Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedit * more edits * add runasgroup in psp (#10076) * update KubeletPluginsWatcher feature gate (#10205) * generated 1.12 docs * Building Multi-arch images with Manifests (#10379) In 1.12, a variety of images used in a typical kubernetes installation have started to using manifests to better support environments with arm or ppc64le architectures. For example all images used with kubeadm by default have manifests, another would be all the tests in the conformance test suite. Here we capture the best practices for everyone to start using manifests in their own workflows. Change-Id: I5ba4c5fe55ffc9486a8251760f3352be4f2e1494 * Upgrade docs for v1.12 (#10344) * generated assets and docs * remove 1.7 * update 1.12 * update plugin documentation under docs>tasks>extend-kubectl (#10259) * update plugin documentation under docs>tasks>extend-kubectl * Update kubectl-plugins.md

k8s-ci-robot assigned Bradamant3, fabriziopandini and timothysc Sep 13, 2018

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 13, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2018

xiangpengzhao reviewed Sep 13, 2018

View reviewed changes

neolit123 force-pushed the master-config-cleanup branch from f0d1f27 to c6a4d0e Compare September 13, 2018 14:33

neolit123 mentioned this pull request Sep 13, 2018

fix some links with 404 error #10287

Merged

timothysc approved these changes Sep 13, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018

xiangpengzhao reviewed Sep 14, 2018

View reviewed changes

neolit123 force-pushed the master-config-cleanup branch from c6a4d0e to 84c8d32 Compare September 14, 2018 03:06

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2018

neolit123 force-pushed the master-config-cleanup branch from 84c8d32 to bd67dd7 Compare September 14, 2018 03:08

xiangpengzhao reviewed Sep 14, 2018

View reviewed changes

fabriziopandini reviewed Sep 15, 2018

View reviewed changes

content/en/docs/reference/setup-tools/kubeadm/implementation-details.md Show resolved Hide resolved

Bradamant3 added this to the 1.12 milestone Sep 15, 2018

neolit123 force-pushed the master-config-cleanup branch from bd67dd7 to 66f4a6c Compare September 17, 2018 14:47

kubeadm: update API types documentation for 1.12

34ffad7

v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types]

neolit123 force-pushed the master-config-cleanup branch from 66f4a6c to 34ffad7 Compare September 17, 2018 14:49

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2018

k8s-ci-robot merged commit 5ab6ae0 into kubernetes:release-1.12 Sep 19, 2018

Bradamant3 mentioned this pull request Sep 19, 2018

Use the new kubeadm api #10345

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: update API types documentation for 1.12 #10283

kubeadm: update API types documentation for 1.12 #10283

neolit123 commented Sep 13, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Sep 13, 2018

k8sio-netlify-preview-bot commented Sep 13, 2018 •

edited

Loading

xiangpengzhao left a comment

xiangpengzhao Sep 13, 2018

neolit123 Sep 13, 2018

xiangpengzhao Sep 13, 2018

neolit123 Sep 13, 2018

zparnold commented Sep 13, 2018

timothysc left a comment

zparnold commented Sep 13, 2018

xiangpengzhao Sep 14, 2018 •

edited

Loading

neolit123 Sep 14, 2018 •

edited

Loading

xiangpengzhao Sep 14, 2018

neolit123 Sep 14, 2018

Bradamant3 Sep 15, 2018

Bradamant3 commented Sep 19, 2018

k8s-ci-robot commented Sep 19, 2018

Bradamant3 commented Sep 19, 2018

kubeadm: update API types documentation for 1.12 #10283

kubeadm: update API types documentation for 1.12 #10283

Conversation

neolit123 commented Sep 13, 2018 • edited Loading

k8sio-netlify-preview-bot commented Sep 13, 2018

k8sio-netlify-preview-bot commented Sep 13, 2018 • edited Loading

xiangpengzhao left a comment

Choose a reason for hiding this comment

xiangpengzhao Sep 13, 2018

Choose a reason for hiding this comment

neolit123 Sep 13, 2018

Choose a reason for hiding this comment

xiangpengzhao Sep 13, 2018

Choose a reason for hiding this comment

neolit123 Sep 13, 2018

Choose a reason for hiding this comment

zparnold commented Sep 13, 2018

timothysc left a comment

Choose a reason for hiding this comment

zparnold commented Sep 13, 2018

xiangpengzhao Sep 14, 2018 • edited Loading

Choose a reason for hiding this comment

neolit123 Sep 14, 2018 • edited Loading

Choose a reason for hiding this comment

xiangpengzhao Sep 14, 2018

Choose a reason for hiding this comment

neolit123 Sep 14, 2018

Choose a reason for hiding this comment

Bradamant3 Sep 15, 2018

Choose a reason for hiding this comment

Bradamant3 commented Sep 19, 2018

k8s-ci-robot commented Sep 19, 2018

Bradamant3 commented Sep 19, 2018

neolit123 commented Sep 13, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Sep 13, 2018 •

edited

Loading

xiangpengzhao Sep 14, 2018 •

edited

Loading

neolit123 Sep 14, 2018 •

edited

Loading