Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some links with 404 error #10287

Merged
merged 1 commit into from
Oct 4, 2018
Merged

fix some links with 404 error #10287

merged 1 commit into from
Oct 4, 2018

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 13, 2018

Fix some links with 404 error.
I have checked the validity of all links started with "https://godoc.org"!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Sep 13, 2018

/assign @chenopis

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 13, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c88ce6d

https://deploy-preview-10287--kubernetes-io-master-staging.netlify.com

@neolit123
Copy link
Member

/hold
@SataQiu thanks!

please remove the kubeadm* releated changes because it duplicates with my PR here:
#10283

the minikube changes are fine!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2018
@Rajakavitha1
Copy link
Contributor

@SataQiu Thanks for the fix. The fixes for minikube on https://deploy-preview-10287--kubernetes-io-master-staging.netlify.com/docs/setup/minikube/ look good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2018
@neolit123
Copy link
Member

please remove the kubeadm* releated changes because it duplicates with my PR here:
#10283

LGTM, thanks

@SataQiu
Copy link
Member Author

SataQiu commented Sep 25, 2018

Thanks！I have removed the kubeadm* releated changes. @neolit123

@neolit123
Copy link
Member

thanks
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018
@tengqm
Copy link
Contributor

tengqm commented Sep 25, 2018

/lgtm

@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 32fdce6 into kubernetes:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@tengqm tengqm

@bradtopol bradtopol

@chenopis chenopis

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@SataQiu @k8sio-netlify-preview-bot @neolit123 @Rajakavitha1 @tengqm @zparnold @k8s-ci-robot @bradtopol @chenopis @kubernetes-docs-i18n-bot