Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docker installation instructions #17347

Closed
wants to merge 34 commits into from
Closed

Update Docker installation instructions #17347

wants to merge 34 commits into from

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 1, 2019

The docs for installing Docker are a bit outdated. kubernetes/kubernetes#82326 (comment)
Thanks for clarifying and suggesting this @neolit123.

kbhawkey and others added 30 commits October 26, 2019 07:31
@kbhawkey @k8s-ci-robot
Fix styling of tutorial pages (kubernetes#17177)
c26ea07 
* [WIP] Fix styling of tutorial pages

* additional cleanup of styles.css
@Dirc @k8s-ci-robot
fix typo (kubernetes#17188)
998fb53
@andrewsykim @k8s-ci-robot
redirect to vSphere cloud provider docs in cloud providers page (kube…
f53c6e1 
…rnetes#16778)

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@ChaitanyaKaranam @k8s-ci-robot
Accessibility updates - main landmark roles (kubernetes#17106)
6a4238a 
* Removed multiple main tags from home page

Signed-off-by: chaitanyakaranam <chaitanya.karanam@yahoo.com>

* Removed multiple occurances of main in case-studies page

Signed-off-by: chaitanyakaranam <chaitanya.karanam@yahoo.com>

* Replaced css for main tag with .main-section class

Signed-off-by: ChaitanyaKaranam <karanam.krishna.25@gmail.com>

* Added main landmark role for all the pages

Signed-off-by: ChaitanyaKaranam <karanam.krishna.25@gmail.com>

* Force checks.

request-checks: true
@wahyuoi @girikuncoro @k8s-ci-robot
Translating Organize Cluster Access to ID Localization (kubernetes#17035
7c87be5 
)

* Translating "Organizing Cluster Access Using kubeconfig Files" to ID Localization

* Apply suggestions from code review

Co-Authored-By: Giri Kuncoro <girikuncoro@users.noreply.github.com>
@aimeeu @k8s-ci-robot
Update work from a local clone section (kubernetes#16748)
99895de 
Add content based on Slack thread
https://kubernetes.slack.com/archives/C1TU9EB9S/p1570736679005700

Change -f to --force-with-lease
Simplified wording

Signed-off-by: Aimee Ukasick <aimeeu.opensource@gmail.com>
@zacharysarah @k8s-ci-robot
Update master to Hugo version 0.57.2 (kubernetes#16814)
41ea6d4 
Update Makefile for 0.57.2
@natereid72 @k8s-ci-robot
Update declare-network-policy.md (kubernetes#17234)
4b33e8a
@liggitt @k8s-ci-robot
Fix webhook admission example (kubernetes#17179)
aad4f0b
@rouralberto @k8s-ci-robot
Update alibaba-cloud.md (kubernetes#17156)
8d115c5 
Alibaba Cloud supports serverless kubernetes, a Kubernetes-In-Kubernetes based solution.
@chiefy @k8s-ci-robot
Update cluster-management.md (kubernetes#17150)
18e3f8d 
* Update cluster-management.md

Fix link to version-skew upgrade doc

* Update cluster-management.md

fix pathing
@vanou @k8s-ci-robot
Fixes commands not working without sudo (kubernetes#17139)
4fe0eaa 
In doc of kubeadm installation, there are commands which wont work
without sudo regarding to Ubuntu/Debian instruction. However, other
docs related to kubeadm under
content/en/docs/setup/production-environment have commands with sudo.

This commit fixes this inconsistency.
@wmcg @k8s-ci-robot
Remove duplicate reference to awsElasticBlockStore (kubernetes#17135)
fbca7bb
@jakowicz @k8s-ci-robot
Update network-plugins.md (kubernetes#17109)
b2f7b2f 
* Update network-plugins.md

* Update network-plugins.md
@miteshskj @k8s-ci-robot
Update k8s version info for etcd encryption feature in securing-a-clu…
7fa51c9 
…ster. (kubernetes#17027)
@lex111 @k8s-ci-robot
Improve Concepts section (kubernetes#17013)
f120439 
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
@aimeeu @k8s-ci-robot
2019 Kubernetes Documentation Survey results (kubernetes#16462)
ae34e1a 
* 2019 Kubernetes Documentation Survey results

Incoporate reviewer feedback
Text and image
Add github location

Signed-off-by: Aimee Ukasick <aimeeu.opensource@gmail.com>

* Update and rename 2019-sig-docs-survey.md to 2019-10-29-2019-sig-docs-survey.md
@prabangkoro @k8s-ci-robot
translate poseidon firmament alternate scheduler (kubernetes#17043)
d527b60
@giom-l @k8s-ci-robot
replace with dashes all points present in url fields to fix links (ku…
2384066 
…bernetes#17286)
@lojies @k8s-ci-robot
fix issue 17274 (kubernetes#17277)
8db2d7b
@lojies @k8s-ci-robot
fix err url of minikube (kubernetes#17273)
de84e18
@jimangel @k8s-ci-robot
fixed yaml block so it renders (kubernetes#17259)
647b4cd
@lojies @k8s-ci-robot
fix param error (kubernetes#17249)
4b42817
@lojies @k8s-ci-robot
change the contianer runtime link to the correct id (kubernetes#17245)
20694c7
@drnic @k8s-ci-robot
base64 --decode works across Linux and MacOS (kubernetes#17240)
cdc5900 
Signed-off-by: Dr Nic Williams <drnicwilliams@gmail.com>
@tengfei86 @k8s-ci-robot
Update horizontal-pod-autoscale-walkthrough.md (kubernetes#17206)
f65a6fe
@lojies @k8s-ci-robot
fix error link (kubernetes#17253)
c3444e3
@girikuncoro @k8s-ci-robot
Add Indonesian translation for object-management page (kubernetes#16854)
c324bfd
@miteshskj @k8s-ci-robot
Add link to styles.css stylesheet in index.html under kubernetes-basi…
b44116f 
…cs. (kubernetes#17051)
@ysyukr @k8s-ci-robot
Edit link in document for issue kubernetes#16908 (kubernetes#16909)
1e4eb26 
* Edit link in document.

* Update nodes.md
@k8s-ci-robot
Copy link
Contributor

Welcome @hakman!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tfogo
You can assign the PR to them by writing /assign @tfogo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 1, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 718b2fc

https://deploy-preview-17347--kubernetes-io-master-staging.netlify.com

@hakman
Copy link
Member Author

hakman commented Nov 1, 2019

/assign @tfogo
/assign @neolit123

@neolit123
Copy link
Member

neolit123 commented Nov 1, 2019 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2019
@daminisatya
Copy link
Contributor

Perfect Thank you so much @hakman

/lgtm

@hakman
Copy link
Member Author

hakman commented Nov 4, 2019

Thanks a lot @neolit123 @daminisatya. This was very fast.
Please let me know if there is anything else I need to do and if I need to cherrypick this on other branches also.

@hakman hakman mentioned this pull request Nov 4, 2019
Merged
@neolit123
Copy link
Member

neolit123 commented Nov 4, 2019 •
edited
Loading

Please let me know if there is anything else I need to do and if I need to cherrypick this on other branches also.

i'm pretty sure, the k/website repository does not allow cherry pics.

@hakman
Copy link
Member Author

hakman commented Nov 4, 2019

i'm pretty sure, the k/website repository does not allow cherry pics.

Guess it was a n00b question :).
Meant if there is any need to create PR for the dev-1.17 or release-1.16 branches.

@neolit123
Copy link
Member

given we are targeting 1.17 with this change then ideally this PR here should be against the dev-1.17 branch and this should be the only PR.

@hakman hakman changed the base branch from master to dev-1.17 November 4, 2019 16:05
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2019
@hakman hakman closed this Nov 4, 2019
@hakman hakman deleted the docker-19.04.3 branch November 4, 2019 16:17
@hakman hakman mentioned this pull request Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@neolit123 neolit123

@tfogo tfogo

@daminisatya daminisatya

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.