Updating EndpointSlice documentation for beta release in 1.17 #17411

robscott · 2019-11-04T22:26:53Z

This updates the EndpointSlice documentation for the beta release targeted for v1.17.

EndpointSlice Beta PR: kubernetes/kubernetes#84390
EndpointSlice Enhancement Issue: kubernetes/enhancements#752

k8sio-netlify-preview-bot · 2019-11-04T22:26:58Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 73c7698

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dd8296092e03b0008978d43

makoscafee · 2019-11-04T22:46:01Z

/milestone 1.17

content/en/docs/reference/command-line-tools-reference/feature-gates.md

sftim · 2019-11-05T10:03:10Z

content/en/docs/concepts/services-networking/endpoint-slices.md

@@ -26,7 +26,7 @@ Endpoints.

 ## Endpoint Slice resources {#endpointslice-resource}

-In Kubernetes, an Endpoint Slice contains references to a set of network
+In Kubernetes, an EndpointSlice contains references to a set of network
 endpoints. The EndpointSlice controller automatically creates Endpoint Slices


(if #16885 lands, I can add a page about that specific controller).

Nice! I've got some slides that help explain the logic in that controller if that's helpful.

content/en/docs/concepts/services-networking/endpoint-slices.md

daminisatya · 2019-11-20T09:37:41Z

@robscott

Just a reminder about the last Docs deadline - 22nd Nov, by which this PR needs to be merged!

robscott · 2019-11-21T00:11:35Z

Hey @daminisatya, thanks for the reminder! This fell through the cracks between code freeze and KubeCon. I've made a round of updates and this is ready for another round of review.

tengqm · 2019-11-21T02:12:03Z

/approve

kbhawkey · 2019-11-21T20:51:36Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -86,7 +86,8 @@ different Kubernetes components.
 | `DynamicAuditing` | `false` | Alpha | 1.13 | |
 | `DynamicKubeletConfig` | `false` | Alpha | 1.4 | 1.10 |
 | `DynamicKubeletConfig` | `true` | Beta | 1.11 | |
-| `EndpointSlice` | `false` | Alpha | 1.16 | |
+| `EndpointSlice` | `false` | Alpha | 1.16 | 1.16 |
+| `EndpointSlice` | `false` | Beta | 1.17 | |


@robscott , should line 90 set the beta feature gate to true?

Sadly no, we ended up switching it to disabled by default (kubernetes/kubernetes#85365)

OK. I was under the impression that all beta features were enabled by default.

kbhawkey · 2019-11-21T20:56:41Z

content/zh/docs/concepts/services-networking/endpoint-slices.md

@@ -127,6 +127,6 @@ Endpoints API 提供了一种简单明了的方法在 Kubernetes 中跟踪网络
 * [Enabling Endpoint Slices](/docs/tasks/administer-cluster/enabling-endpoint-slices)
 * Read [Connecting Applications with Services](/docs/concepts/services-networking/connect-applications-service/)
 -->
-* [启用 Endpoint Slices](/docs/tasks/administer-cluster/enabling-endpoint-slices)
+* [启用 Endpoint Slices](/docs/tasks/administer-cluster/enabling-endpoint-slices


@robscott Do you intend to add further updates this page (the YAML)?

Woops, thanks for catching that! Originally the plan was for EndpointSlices to be enabled by default, so I'd removed this in the initial version of the PR. As it turns out, this wasn't deemed quite stable enough to be enabled by default so I had to bring this back, and I messed up adding this back in the first time.

Not sure what happened here. Are you missing the end paren?

That was something I missed the first time I tried to revert my initial removal of that link. I pushed a fix for that yesterday so there should be no changes to the zh version of this file left in this PR. Sorry for the confusion there!

daminisatya · 2019-11-22T17:06:39Z

@kbhawkey Is this pr good to go?

content/en/docs/concepts/services-networking/endpoint-slices.md

kbhawkey · 2019-11-22T18:27:00Z

Page preview:
https://deploy-preview-17411--kubernetes-io-vnext-staging.netlify.com/docs/concepts/services-networking/endpoint-slices/

https://deploy-preview-17411--kubernetes-io-vnext-staging.netlify.com/docs/concepts/services-networking/service/

https://deploy-preview-17411--kubernetes-io-vnext-staging.netlify.com/docs/reference/command-line-tools-reference/feature-gates/

daminisatya · 2019-11-22T18:48:45Z

/lgtm
/approve

k8s-ci-robot · 2019-11-22T18:49:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [daminisatya,tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2019

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 4, 2019

k8s-ci-robot requested review from bowei and bprashanth November 4, 2019 22:27

k8s-ci-robot added this to the 1.17 milestone Nov 4, 2019

tengqm reviewed Nov 5, 2019

View reviewed changes

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved

sftim reviewed Nov 5, 2019

View reviewed changes

kbhawkey mentioned this pull request Nov 10, 2019

add enable Endpoint Slices #17480

Closed

robscott force-pushed the endpointslice-beta branch 2 times, most recently from 5904449 to 4a4df51 Compare November 21, 2019 00:07

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019

kbhawkey reviewed Nov 21, 2019

View reviewed changes

robscott force-pushed the endpointslice-beta branch from 4a4df51 to 6509c43 Compare November 21, 2019 22:23

kbhawkey reviewed Nov 22, 2019

View reviewed changes

content/en/docs/concepts/services-networking/endpoint-slices.md Show resolved Hide resolved

Updating EndpointSlice documentation for beta release in 1.17

73c7698

robscott force-pushed the endpointslice-beta branch from 6509c43 to 73c7698 Compare November 22, 2019 18:30

k8s-ci-robot assigned daminisatya Nov 22, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019

k8s-ci-robot merged commit 1c77372 into kubernetes:dev-1.17 Nov 22, 2019

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Updating EndpointSlice documentation for beta release in 1.17 (#17411)

6e6f90a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating EndpointSlice documentation for beta release in 1.17 #17411

Updating EndpointSlice documentation for beta release in 1.17 #17411

robscott commented Nov 4, 2019

k8sio-netlify-preview-bot commented Nov 4, 2019 •

edited

Loading

makoscafee commented Nov 4, 2019

sftim Nov 5, 2019

robscott Nov 21, 2019

daminisatya commented Nov 20, 2019

robscott commented Nov 21, 2019

tengqm commented Nov 21, 2019

kbhawkey Nov 21, 2019

robscott Nov 21, 2019

kbhawkey Nov 22, 2019

kbhawkey Nov 21, 2019

robscott Nov 21, 2019

kbhawkey Nov 22, 2019

robscott Nov 22, 2019

kbhawkey Nov 22, 2019

daminisatya commented Nov 22, 2019

kbhawkey commented Nov 22, 2019 •

edited

Loading

daminisatya commented Nov 22, 2019

k8s-ci-robot commented Nov 22, 2019

Updating EndpointSlice documentation for beta release in 1.17 #17411

Updating EndpointSlice documentation for beta release in 1.17 #17411

Conversation

robscott commented Nov 4, 2019

k8sio-netlify-preview-bot commented Nov 4, 2019 • edited Loading

makoscafee commented Nov 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daminisatya commented Nov 20, 2019

robscott commented Nov 21, 2019

tengqm commented Nov 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daminisatya commented Nov 22, 2019

kbhawkey commented Nov 22, 2019 • edited Loading

daminisatya commented Nov 22, 2019

k8s-ci-robot commented Nov 22, 2019

k8sio-netlify-preview-bot commented Nov 4, 2019 •

edited

Loading

kbhawkey commented Nov 22, 2019 •

edited

Loading