Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enable Endpoint Slices #17480

Closed
wants to merge 1 commit into from
Closed

add enable Endpoint Slices #17480

wants to merge 1 commit into from

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Nov 8, 2019

When running the example in page https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/ , it failed with errors like this:

kubectl create -f eps.yaml
error: unable to recognize "eps.yaml": no matches for kind "EndpointSlice" in version "discovery.k8s.io/v1alpha1"

Add enable Endpoint Slices.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jimangel
You can assign the PR to them by writing /assign @jimangel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from freehan and sftim November 8, 2019 01:10
@netlify
Copy link

netlify bot commented Nov 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 10c6760

https://deploy-preview-17480--kubernetes-io-master-staging.netlify.com

sftim
sftim reviewed Nov 8, 2019
View reviewed changes
content/en/docs/concepts/services-networking/endpoint-slices.md
@@ -59,6 +59,8 @@ endpoints:
topology.kubernetes.io/zone: us-west2-a
```

Additionally, you must [enable Endpoint Slices](/docs/tasks/administer-cluster/enabling-endpoint-slices/#enabling-endpoint-slices) first.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this detail to the start of the main contents (say line 26)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the link to the task is on line 91 of this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey, is it better to introduce this at the start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim, moving this to the start is ok.

Copy link
Contributor

@kbhawkey kbhawkey Nov 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lojies , this page introduces the alpha feature, Endpoint Slices, and does not necessarily provide steps to create a working example.

Also, it looks like this feature is changing to beta in 1.17. See PR #17411 . Looks like the task page is going away.

I don't think the page needs two links to the Endpoint Slices task page. If you want to add a statement about enabling the feature gate, you may want to add a bit more context.
Suggestions:

See the What's next section for information about enabling Endpoint Slices.
or
You can follow the Endpoint Slices task to enable the Endpoint Slices feature.

Page preview:
https://deploy-preview-17480--kubernetes-io-master-staging.netlify.com/docs/concepts/services-networking/endpoint-slices/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey , thanks for the suggestion.I will close this pr.

@lojies lojies closed this Nov 11, 2019
@sftim sftim mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@freehan freehan Awaiting requested review from freehan

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lojies @k8s-ci-robot @kbhawkey @sftim