Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add migration guide to scheduler v1beta3 #30404

Merged
merged 1 commit into from
Nov 25, 2021
Merged

add migration guide to scheduler v1beta3 #30404

merged 1 commit into from
Nov 25, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Nov 9, 2021

part of ##30063
add scheduler api migration guide from v1beta2 -> v1beta3

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 9, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 9, 2021
@netlify
Copy link

netlify bot commented Nov 9, 2021 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 74dcb53

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/619f0283c1f77e0007ec7a24

@kerthcet
Copy link
Member Author

kerthcet commented Nov 9, 2021

Cherry-pick from c059c31b757a0969aa8 as some document struct changed in this commit.

@kerthcet
Copy link
Member Author

kerthcet commented Nov 9, 2021

/cc @alculquicondor

@kerthcet kerthcet changed the title Feature/add migration guide to scheduler v1beta3 add migration guide to scheduler v1beta3 Nov 9, 2021
@alculquicondor
Copy link
Member

/cc @damemi

@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from 490b875 to 79753e7 Compare November 10, 2021 07:23
@jlbutler
Copy link
Contributor

/assign @nate-double-u

@nate-double-u
Copy link
Contributor

nate-double-u commented Nov 15, 2021 •
edited

Deploy previews:

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from 79753e7 to 02fd119 Compare November 18, 2021 02:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2021
@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from 02fd119 to dffa55a Compare November 18, 2021 02:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021
@kerthcet
Copy link
Member Author

any progress about this pr? @nate-double-u

nate-double-u
nate-double-u reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kerthcet. From a docs POV, this looks good. I think we still need a technical /lgtm to move this forward. @alculquicondor, @damemi are either of you able to provide that?

/lgtm

content/en/docs/reference/scheduling/config.md Show resolved Hide resolved
@jlbutler
Copy link
Contributor

@kerthcet PTAL at latest comment from @alculquicondor, approved pending resolution of that. Thanks!

@alculquicondor
Copy link
Member

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 24, 2021
@damemi damemi mentioned this pull request Nov 24, 2021
Merged
@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from 5ca4563 to a92f5ac Compare November 24, 2021 16:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2021
@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from a92f5ac to fba0420 Compare November 24, 2021 17:27
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8102fa60449d76b69e82f44fdcd1de96d909b6b8

@kerthcet
add migration docs for scheduler component config api from v1beta2 to…
74dcb53 
… v1beta3

Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feature/add-migration-to-scheduler-v1beta3 branch from fba0420 to 74dcb53 Compare November 25, 2021 03:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2021
sftim
sftim reviewed Nov 25, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged.
I'll PR a tweak to drop scheduling policies from the sitemap,with

sitemap:
  priority: 0.2

in the front matter.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2021
@sftim
Copy link
Contributor

sftim commented Nov 25, 2021

Happy with changes since #30404 (comment)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98d2e5cacb590d2f7108bf0a23287b48f35cc447

@k8s-ci-robot k8s-ci-robot merged commit 46b8ceb into kubernetes:dev-1.23 Nov 25, 2021
@kerthcet kerthcet deleted the feature/add-migration-to-scheduler-v1beta3 branch November 25, 2021 14:37
This was referenced Nov 25, 2021
Closed
Merged
Closed
@sftim sftim mentioned this pull request Nov 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@nate-double-u nate-double-u nate-double-u left review comments

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla left review comments

@sftim sftim sftim left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@jimangel jimangel Awaiting requested review from jimangel

@damemi damemi Awaiting requested review from damemi

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@alculquicondor alculquicondor

@nate-double-u nate-double-u

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kerthcet @alculquicondor @jlbutler @nate-double-u @k8s-ci-robot @sftim @ravisantoshgudimetla