Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-emphasize deprecated scheduling policies for v1.23 and later #30658

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 28, 2021

Scheduling priorities are deprecated, so:

  • move the page later in the parent topic
  • hint that it's not a priority in the sitemap for the live docs

Follow -up to #30404

/milestone 1.23
/kind cleanup

Scheduling priorities are deprecated, so:
- move the page later in the parent topic
- hint that it's not a priority in the sitemap for the live docs
@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2021
@netlify
Copy link

netlify bot commented Nov 28, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: b8a9bae

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61a3d358358d7700091f4e43

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 28, 2021
@@ -1,7 +1,8 @@
---
title: Scheduling Policies
content_type: concept
weight: 10
sitemap:
priority: 0.2 # Scheduling priorities are deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know, how this priority is to be set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most pages are 0.9, a few special ones get 1.0

I picked 0.2 because it's a lot less than 0.9 (this is the first low-priority page we've done).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, default priority is 0.75 not 0.9

@jlbutler
Copy link
Contributor

jlbutler commented Dec 1, 2021

/assign

Copy link
Contributor

@mehabhalodiya mehabhalodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ready to merge!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2da049876f9c1b7a6dc3390050e687353bd7744b

@jlbutler
Copy link
Contributor

jlbutler commented Dec 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler, mehabhalodiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 11b24e5 into kubernetes:dev-1.23 Dec 2, 2021
@sftim sftim deleted the 20211128_de-emphasize_deprecated_scheduling_policies branch December 8, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants