Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list of container runtimes tested with v1.24 #34455

Closed
wants to merge 1 commit into from

Conversation

chetak123
Copy link
Member

@chetak123 chetak123 commented Jun 22, 2022

Fixes #33511

I have removed the CNI-pluggin related error example which goes stale in v1.25.

Can we update the containerd example to v1.6.6 and CRI-O to v1.24.1 (latest release) instead of deleting it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign onlydole after the PR has been reviewed.
You can assign the PR to them by writing /assign @onlydole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 22, 2022
@netlify
Copy link

netlify bot commented Jun 22, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 483b62f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62b26dcf1cc2b80008cd4bc3
😎 Deploy Preview https://deploy-preview-34455--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mehabhalodiya
Copy link
Contributor

Hi @chetak123 Could you please update the description to "Fixes #33511" i.e this indicates the issue is resolved.

By doing so, whenever a PR gets merged into the main branch, the corresponding issue gets closed, thus avoiding manual closing of the issues 🙂

@chetak123
Copy link
Member Author

chetak123 commented Jun 22, 2022

Hi @chetak123 Could you please update the description to "Fixes #33511" i.e this indicates the issue is resolved.

By doing so, whenever a PR gets merged into the main branch, the corresponding issue gets closed, thus avoiding manual closing of the issues 🙂

Should we add it in PR template like

#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

because I think a lot of people may make this mistake
@mehabhalodiya

@@ -13,11 +13,6 @@ To avoid CNI plugin-related errors, verify that you are using or upgrading to a
container runtime that has been tested to work correctly with your version of
Kubernetes.

For example, the following container runtimes are being prepared, or have already been prepared, for Kubernetes v1.24:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest having the container runtimes provide a link to a .md support table that will not go stale. Then link from here..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or if there is a location in k8s doc space that provides a "tested" table that would suffice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing completely begs the question.. what has been tested to work... Cheers, Mike

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim
Copy link
Contributor

sftim commented Jul 12, 2022

/retitle Remove list of container runtimes tested with v1.24

@k8s-ci-robot k8s-ci-robot changed the title removed stale example Remove list of container runtimes tested with v1.24 Jul 12, 2022
@sftim
Copy link
Contributor

sftim commented Jul 12, 2022

This PR is against the main branch. @chetak123 you can either:

  • update the base branch of this PR to dev-1.25, rebase it, and force-push
  • make a new PR that's against dev-1.25, and close this PR. Mention the new PR in a comment before you close this one.

/hold
OK to unhold once the PR targets dev-1.25

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@chetak123
Copy link
Member Author

Hey @sftim ,
I have created the new PR against dev-1.25 #35047

@chetak123 chetak123 closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Troubleshooting CNI plugin-related errors for v1.25 docs
5 participants