Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list of container runtimes tested with v1.24 #35047

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

chetak123
Copy link
Member

Fixes #33511

I have removed the CNI-pluggin related error example which goes stale in v1.25.

Can we update the containerd example to v1.6.6 and CRI-O to v1.24.1 (latest release) instead of deleting it.

PR related to #34455

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5246ba4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62d1107075b64f0008641e20

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 15, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the containerd example to v1.6.6 and CRI-O to v1.24.1 (latest release) instead of deleting it.

I think the right thing to do is to omit the list. Our official conformance tests cover distributions, not specific component pairings.

/lgtm
/approve

@sftim
Copy link
Contributor

sftim commented Jul 17, 2022

/milestone 1.25

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b7ef3313b2b84992e75fb131541530206cbed6e

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Jul 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Jul 17, 2022

/sig node

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 27658d9 into kubernetes:dev-1.25 Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants