Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kube-proxy iptables performance optimization notes #38435

Merged
merged 1 commit into from
Dec 23, 2022
Merged

add kube-proxy iptables performance optimization notes #38435

merged 1 commit into from
Dec 23, 2022

Conversation

danwinship
Copy link
Contributor

This adds some basic documentation about the kube-proxy iptables syncPeriod and minSyncPeriod config options, and how MinimizeIPTablesRestore in 1.26 changes that.

spun off from #37649 which got auto-closed when dev-1.26 was deleted, but we wanted to change the focus of the documentation anyway, as discussed in #37649 (comment)

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim December 12, 2022 18:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6afbc1d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/639b7023cde5ef00088e5da3
😎 Deploy Preview https://deploy-preview-38435--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid using level 5 headings; however, I'm actually happy to make an exception here. These are niche details.

I've provided feedback inline.

content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
@danwinship danwinship force-pushed the iptables-proxy-performance branch from d70cded to 656f987 Compare December 13, 2022 21:37
@sftim
Copy link
Contributor

sftim commented Dec 13, 2022

I can't review this for technical accuracy though I'm afraid. @danwinship could you recommend someone who can?

@sftim
Copy link
Contributor

sftim commented Dec 13, 2022

Informally LGTM for docs.

@danwinship
Copy link
Contributor Author

/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea December 14, 2022 15:46
@danwinship danwinship force-pushed the iptables-proxy-performance branch from 656f987 to 6afbc1d Compare December 15, 2022 19:06
@aojea
Copy link
Member

aojea commented Dec 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 503c04374764d1c307d5e53ea0225f3509707dcd

@aojea
Copy link
Member

aojea commented Dec 15, 2022

/approve

divya-mohan0209
divya-mohan0209 reviewed Dec 23, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 957a4ed into kubernetes:main Dec 23, 2022
@danwinship danwinship mentioned this pull request Jan 6, 2023
Closed
15 tasks
@danwinship danwinship deleted the iptables-proxy-performance branch January 6, 2023 16:30
@danwinship danwinship mentioned this pull request Jan 31, 2023
Merged
@aj11anuj aj11anuj mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@aojea aojea aojea left review comments

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danwinship @sftim @aojea @k8s-ci-robot @divya-mohan0209