Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize home/supported-doc-versions.md to Arabic #44698

Conversation

adowair
Copy link

@adowair adowair commented Jan 10, 2024

This commit will add a file content/ar/home/support-doc-versions.md containing an Arabic translation of the content/en counterpart. This is part of the effort to localize the minimum required documents for a new localization, as outlined in Step 9 of #44682:

  1. Open PRs to localize all minimum-required-contents and a localized README file
    https://kubernetes.io/docs/contribute/localization/#minimum-required-content
    https://kubernetes.io/docs/contribute/localization/#add-a-localized-readme-file
    Note: base and target branches of the PR should be the dev branch of AR.
    Note: at this moment, candidates for Arabic reviewers and approvers do not have an authority yet. However reviews on localized contents from the candidates are required. Use /lgtm to express a PR is ready to be merged.

This pull request replaces #44117.

This commit will add a file `content/ar/home/support-doc-versions.md`
containing an Arabic translation of the `content/en` counterpart.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2024
@dipesh-rawat
Copy link
Member

/language ar

@k8s-ci-robot k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Jan 10, 2024
@sftim
Copy link
Contributor

sftim commented Jan 10, 2024

/retitle Localize home/supported-doc-versions.md to Arabic

(we avoid Markdown in commit messages)

@k8s-ci-robot k8s-ci-robot changed the title Localize home/supported-doc-versions.md to Arabic Localize home/supported-doc-versions.md to Arabic Jan 10, 2024
@sftim
Copy link
Contributor

sftim commented Jan 10, 2024

This is ready for reviews by people who can speak both Arabic and English.

@seifrajhi
Copy link
Member

LGTM for Arabic

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization LGTM: #44698 (comment)

Not a change to the live site.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 629e823154e2c699c6db8f70e1477c248cada972

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4b53bbd into kubernetes:dev-1.29-ar.1 Jan 31, 2024
2 checks passed
@adowair adowair deleted the dev-1.29-ar.1-home/supported-doc-versions branch February 5, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ar Issues or PRs related to Arabic language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants