-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create basic structure and translate home for Arabic #44902
Create basic structure and translate home for Arabic #44902
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for re-opening this @mboukhalfa. I have a draft PR #44862 open for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work. I have some feedback you'd need to account for before we can merge this, even to a branch you're not yet publishing to the live site
- avoid including any English files
- let's split the important CSS change out into its own pull request, so we can make sure we merge the right thing
- one of the localization strings files actually needs to be a symbolic link
/hold
I'd want to omit the change to OWNERS_ALIASES
before removing the hold, and I'd want the PR to avoid including any files with substantial English text before we give this LGTM.
It's impressive, and we're here to help - with some more changes, this can land.
body:lang(ar) { | ||
.navbar-brand { | ||
left: 16px; | ||
} | ||
.announcement-main { | ||
|
||
direction: ltr; | ||
text-align: left; | ||
|
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This change belongs in its own PR.
- Ideally, make it work for all LTR languages and not just Arabic.
SIG Docs can help you make and land that PR in main so that the Arabic work can build upon it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sftim, do you have any plans to address the LTR issue in the main branch?
Is there a possibility of implementing a solution soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to support the work to complete LTR support; I don't plan to work on it all myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely separate it out so it can land as its own change, and into main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should be fixed in https://github.com/google/docsy
reviewers: | ||
- mboukhalfa | ||
- oxPraGa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd omit page-specific reviewers; they don't add much (you can manage the whole team membership instead using OWNERS
files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a symbolic link, not a file. SIG Docs can help you make a symbolic link if you are not sure how to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can, avoid changing this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid including untranslated strings. You can mark what's omitted with a comment, but don't have English text where we eventually want to see Arabic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not in Arabic - let's not include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sig-docs-ar-owners: # Admins for Arabic content | ||
- mboukhalfa | ||
sig-docs-ar-reviews: # PR reviews for Arabic content | ||
- mboukhalfa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, omit this change.
/language ar |
/area localization |
Even though there is more to do, I'd like to invite reviews by people who can speak both Arabic and English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, omit this change (but we can help get it added once the team is up and running).
Hi @mboukhalfa, I suggest we use #44682 to rally active members for the Arabic localization. It's crucial to remember that localizing Kubernetes documents is a complex task due to the sheer volume of content. Maintaining these documents is likely more challenging than setting up the basic configuration for Arabic, and it's a task that cannot be sustained without a committed team of active contributors. (I hope to discuss with contributors who are eligible for reviewer/approver for Arabic content in #44682 . Please note that a candidate needs to be Kubernetes github organization member eventually) With a focus on teamwork and guided steps, I'm hopeful that we will not lose our way and achieve a successful outcome together. 😉 |
cc: @a-mccarthy @natalisucks :) |
Hi @mboukhalfa
(same comment here: #44682 (comment)) |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This partial commit will add some more localizations of strings. Some of these are based on @mboukhalfa's work in kubernetes#44902. Co-authored-by: Mohammed Boukhalfa <mohammedboukhalfa@yandex.com>
Hi @mboukhalfa |
- oxPraGa | ||
title: "ملخص" | ||
description: > | ||
كوبرناتيز عبارة عن نظام أساسي محمول قابل للتوسيع ومفتوح المصدر لإدارة حاويات الخدمات و الإنتاج، مما يسهل الاعدادات التصريحية و التنفيذ الأتوماتيكي. يضم نظام متكامل واسع وسريع النمو. خدمات كوبرناتيز، دعم و الأدوات المتوفرة على نطاق واسع. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change لإدارة حاويات الخدمات و الإنتاج
to لإدارة، جدولة و تنظيم حاويات الخدمات و الإنتاج
Thanks for the feedback I will address the comments ASAP and push |
Close as the content was split into file by file PRs mentioned above |
@mboukhalfa: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the minimal translation related to the file
/home/_index.md