-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Annotation resource.kubernetes.io/pod-claim-name #47093
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -264,6 +264,18 @@ in the StatefulSet topic for more details. | |
Note the [PodIndexLabel](/docs/reference/command-line-tools-reference/feature-gates/) | ||
feature gate must be enabled for this label to be added to pods. | ||
|
||
### resource.kubernetes.io/pod-claim-name | ||
|
||
Type: Annotation | ||
|
||
Example: `resource.kubernetes.io/pod-claim-name: "my-pod-claim"` | ||
|
||
Used on: Pod | ||
|
||
This annotation is assigned to generated ResourceClaims. | ||
Its value corresponds to the `pod.spec.resourceClaims[].name` for which the ResourceClaim was created. | ||
sftim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This annotation is utilized internally by the Kubernetes controller. | ||
sftim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is indeed intentional. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, but per #47044 we don't have a way to register annotations without also documenting them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (adding such a mechanism is welcome, and it's not actually a huge amount of work, but it'd be bigger than this PR) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can document them here. It just makes less sense to also document it in the public types.go as a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. /lgtm |
||
### cluster-autoscaler.kubernetes.io/safe-to-evict | ||
|
||
Type: Annotation | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.