Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster-management.md #4980

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Conversation

hanxiaoshuai
Copy link
Contributor

@hanxiaoshuai hanxiaoshuai commented Aug 16, 2017

modify "some node is not needed" to "some nodes are not needed"


This change is Reviewable

modify "some node is not needed" to "some nodes are not needed"
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 16, 2017

Deploy preview ready!

Built with commit a4c3c7e

https://deploy-preview-4980--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

steveperry-53 commented Aug 17, 2017

@hanxiaoshuai, I don't agree with this change. It can be only one node. So "some node" is fine. "Cluster autoscaler also scales down the cluster if it notices that some node is not needed anymore ..."

Or we could go with something like, "one or more nodes."

@hanxiaoshuai
Copy link
Contributor Author

@steveperry-53 Thanks for your suggestion

@zacharysarah
Copy link
Contributor

LGTM

@zacharysarah zacharysarah merged commit d48707c into kubernetes:master Oct 2, 2017
cnef pushed a commit to ghostcloud-cn/kubernetes.github.io that referenced this pull request Oct 3, 2017
…hub.io into format-example-code

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Remove broken link (kubernetes#5726)
  unified style (kubernetes#5725)
  Fixes in style and more on CDK (kubernetes#5292)
  Use code style for inline code and commands (kubernetes#5724)
  Fix link. (kubernetes#5723)
  Update distribute-credentials-secure.md (kubernetes#5169)
  Update documentation for vSphere Persistent Volume support (kubernetes#5465)
  Update _redirects
  Update scale-intro.html
  Update cluster-management.md (kubernetes#4980)
  ingress grammar/spelling updates (kubernetes#5721)
  Fix an incorrect flag in configure-upgrade-etcd.md (kubernetes#5304)
  Updated PR template for GH workaround (kubernetes#5719)
  separate commands from output (kubernetes#5718)
  explain how to enable heapster on minikube (kubernetes#5710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants