Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR template for GH workaround #5719

Merged
merged 4 commits into from
Oct 2, 2017
Merged

Updated PR template for GH workaround #5719

merged 4 commits into from
Oct 2, 2017

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Oct 2, 2017

This PR is a workaround for a known issue with the GitHub UI for allowing edits from maintainers.

I'd love nothing more than to have to revert this PR tomorrow. 😭


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 53e2e35

https://deploy-preview-5719--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor Author

@steveperry-53 Thoughts?

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit cc44090

https://deploy-preview-5719--kubernetes-io-master-staging.netlify.com

@steveperry-53 steveperry-53 merged commit 749d64a into kubernetes:master Oct 2, 2017
cnef pushed a commit to ghostcloud-cn/kubernetes.github.io that referenced this pull request Oct 3, 2017
…hub.io into format-example-code

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Remove broken link (kubernetes#5726)
  unified style (kubernetes#5725)
  Fixes in style and more on CDK (kubernetes#5292)
  Use code style for inline code and commands (kubernetes#5724)
  Fix link. (kubernetes#5723)
  Update distribute-credentials-secure.md (kubernetes#5169)
  Update documentation for vSphere Persistent Volume support (kubernetes#5465)
  Update _redirects
  Update scale-intro.html
  Update cluster-management.md (kubernetes#4980)
  ingress grammar/spelling updates (kubernetes#5721)
  Fix an incorrect flag in configure-upgrade-etcd.md (kubernetes#5304)
  Updated PR template for GH workaround (kubernetes#5719)
  separate commands from output (kubernetes#5718)
  explain how to enable heapster on minikube (kubernetes#5710)
@zacharysarah zacharysarah deleted the broken-stair branch October 3, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants