Improve DNS documentation #6479

tengqm · 2017-11-29T04:35:45Z

This PR reorgs the DNS documentation so that

the concepts page have dnsPolicy and dnsConfig documented
the diagnosis contents moved over to task
the known issues are moved over to admin task as well
docs about old behaviors are moved to the end of the concepts page as reference

This change is

tengqm · 2017-11-29T04:36:59Z

/assign @steveperry-53
This is a rebase of #6441, now aiming release-1.9 as suggested.

k8sio-netlify-preview-bot · 2017-11-29T04:39:05Z

Deploy preview ready!

Built with commit e371c31

https://deploy-preview-6479--kubernetes-io-vnext-staging.netlify.com

MrHohn · 2017-11-29T08:28:26Z

This is still on my list.
/assign

MrHohn

Thanks for the works, our DNS docs surely need to be improved.

MrHohn · 2017-11-29T23:02:58Z

docs/concepts/services-networking/dns-pod-service.md

 ---

 * TOC
 {:toc}

-## Introduction
+{% capture body %}



Saw this error on https://deploy-preview-6479--kubernetes-io-vnext-staging.netlify.com/docs/concepts/services-networking/dns-pod-service/:

ERROR: You must define a overview block

MrHohn · 2017-11-29T23:36:44Z

docs/concepts/services-networking/dns-pod-service.md

+  for details on how DNS queries are handled in those cases.
+- "`ClusterFirstWithHostNet`": For Pods running with hostNetwork, you should
+  explicitly set its DNS policy "`ClusterFirstWithHostNet`".
+- "`None`": A new option value introduced in Kubernetes v1.9. This allows a Pod


We should indicate this is Alpha in v1.9.

MrHohn · 2017-11-29T23:40:50Z

docs/concepts/services-networking/dns-pod-service.md

+Kubernetes v1.9 introduces an Alpha feature that allows users more control on
+the DNS settings for a Pod. To enable this feature, the cluster aministrator
+needs to enable the `CustomPodDNS` feature gate on the apiserver and the kubelet,
+for example, "`--feature-gates=CustomPodDNS=true,...".


nit: missed a `

"`--feature-gates=CustomPodDNS=true,..." -> "`--feature-gates=CustomPodDNS=true,...`"

MrHohn · 2017-11-29T23:44:32Z

docs/concepts/services-networking/dns-pod-service.md

+Below are the properties a user can specify in the `dnsConfig` field:
+
+- `nameservers`: a list of IP addresses that will be used as DNS servers for the
+  Pod. There may be at most 3 IP addresses specified. When the Pod's `dnsPolicy`


There may be sounds uncertain, probably just At most 3 IP addresses can be specified?

may be ... is different from "maybe", :)

MrHohn · 2017-11-29T23:48:35Z

docs/concepts/services-networking/dns-pod-service.md

+  property will be merged to the options generated from the specified DNS policy.
+  Duplicate entries are removed.
+
+


Do you mind including some concrete examples here? Probably copy from https://github.com/kubernetes/community/blob/master/contributors/design-proposals/network/pod-resolv-conf.md#pod-api-examples.

Oh, or may be put them into the example section in the task doc.

Will do. It is good to have examples when introducing a concept.

MrHohn · 2017-11-30T00:03:32Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

+## References
+
+- [Docs for the DNS cluster addon](http://releases.k8s.io/{{page.githubbranch}}/cluster/addons/dns/README.md)
+


Probably worth linking back to the concept doc (dns-pod-service.md)?

MrHohn · 2017-11-30T00:17:32Z

docs/concepts/services-networking/dns-pod-service.md

+Since v1.3, the `hostname` field of an endpoint address in the Endpoints object
+takes precedence over the hostname value that might have been specified via the 
+`endpoints.beta.kubernetes.io/hostnames-map` annotation. The annotation was
+deprecated since.


The annotation was deprecated since. seems incomplete?

MrHohn · 2017-11-30T00:24:11Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

+using the addon manager
+[cluster add-on](http://releases.k8s.io/{{page.githubbranch}}/cluster/addons/README.md).
+
+The running Kubernetes DNS pod holds 3 containers:


Humm..This section seems more like implementation details that should be developer facing. We should probably put these information on https://github.com/kubernetes/dns/blob/master/README.md instead?

Oh just noticed this existed originally. Putting this in introduction might be confusing end users, what about keeping the "How it Works" section and move it somewhere below?

The task is located in "administer-cluster" subdir, so we can assume that the readers are not "end" users.

MrHohn · 2017-11-30T00:48:58Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

+Then create a pod using this file and verify its status:
+
+```
+kubectl create -f busybox.yaml


Adding a $ before the command (and following commands) might make it more clear.

MrHohn · 2017-11-30T00:53:35Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

-## Understanding name resolution in Kubernetes
-
-DNS policies can be set on a per-pod basis. Currently Kubernetes supports two pod-specific DNS policies: “Default” and “ClusterFirst”. These policies are specified with the `dnsPolicy` flag.
+## Impacts on Pods


I think this should be a sub-section under Configure stub-domain and upstream DNS servers?

make senses, moving it down one level

MrHohn

Thanks, this LGTM overall.

MrHohn · 2017-11-30T20:24:28Z

docs/concepts/services-networking/dns-pod-service.md

+
+The following is an example Pod with custom DNS settings:
+
+{% include code.html language="yaml" file="ingress.yaml" ghlink="/docs/concepts/services-networking/custom-dns.yaml" %}


s/ingress.yaml/custom-dns.yaml

BTW it might be better to give out the result resolv.conf content like https://github.com/kubernetes/community/blob/master/contributors/design-proposals/network/pod-resolv-conf.md#pod-api-examples does?

MrHohn · 2017-11-30T20:24:40Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

+using the addon manager
+[cluster add-on](http://releases.k8s.io/{{page.githubbranch}}/cluster/addons/README.md).
+
+The running Kubernetes DNS pod holds 3 containers:


MrHohn · 2017-11-30T20:28:07Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

@@ -100,7 +141,7 @@ Options for the kube-dns `kube-system:kube-dns` ConfigMap:
 | `stubDomains` (optional) | A JSON map using a DNS suffix key (e.g. “acme.local”) and a value consisting of a JSON array of DNS IPs. | The target nameserver may itself be a Kubernetes service. For instance, you can run your own copy of dnsmasq to export custom DNS names into the ClusterDNS namespace. |
 | `upstreamNameservers` (optional) | A JSON array of DNS IPs. | Note: If specified, then the values specified replace the nameservers taken by default from the node’s `/etc/resolv.conf`. Limits: a maximum of three upstream nameservers can be specified. |

-## Additional examples
+## Examples


In fact, I think both the "Examples" section and the "ConfigMap options" section above should be under "Configure stub-domain and upstream DNS servers".

MrHohn · 2017-11-30T20:28:56Z

cc @bowei

MrHohn · 2017-12-01T18:15:16Z

docs/concepts/services-networking/dns-pod-service.md


-nslookup: can't resolve 'kubernetes.default'
-```
+{% include code.html language="yaml" file="custon-dns.yaml" ghlink="/docs/concepts/services-networking/custom-dns.yaml" %}


nit: custon -> custom

zacharysarah

Looks good! Mostly minor edits for clarity, but see the note on the Compatibility section: you can probably remove it.

zacharysarah · 2017-12-02T00:04:19Z

docs/concepts/services-networking/dns-pod-service.md

 ---
+{% capture overview %}
+This page provides an overview of the DNS support by Kubernetes.


This page provides an overview of DNS support by Kubernetes.

zacharysarah · 2017-12-02T00:05:29Z

docs/concepts/services-networking/dns-pod-service.md

-The final domain will be "<hostname>.<subdomain>.<pod namespace>.svc.<cluster domain>".
-For example, a Pod with the hostname annotation set to "foo", and the subdomain annotation set to "bar", in namespace "my-namespace", will have the FQDN "foo.bar.my-namespace.svc.cluster.local"
+The Pod spec has an optional `hostname` field, which can be used to specify the
+Pod's hostname. When specified, it takes precedence over the Pod's name, to be


Pod's hostname. When specified, it takes precedence over the Pod's name to be

zacharysarah · 2017-12-02T00:07:18Z

docs/concepts/services-networking/dns-pod-service.md

-`pod.beta.kubernetes.io/subdomain` annotation value.
+The Pod spec also has an optional `subdomain` field which can be used to specify
+its subdomain. For example, a Pod with `hostname` set to "`foo`", and `subdomain`
+set to "`bar`", in namespace "`my-namespace`", will have the FQDN


`set to "`bar`", in namespace "`my-namespace`", will have the fully qualified domain name (FQDN)

So:

set to "bar", in namespace "my-namespace", will have the fully qualified domain name (FQDN)

zacharysarah · 2017-12-02T00:08:42Z

docs/concepts/services-networking/dns-pod-service.md

+If there exists a headless service in the same namespace as the pod and with
+the same name as the subdomain, the cluster's KubeDNS Server also returns an A
+record for the Pod's fully qualified hostname.
+Given a Pod with the hostname set to "`busybox-1`" and the subdomain set to


For example, given a Pod with the hostname set to "`busybox-1`" and the subdomain set to

So:

For example, given a Pod with the hostname set to "busybox-1" and the subdomain set to

zacharysarah · 2017-12-02T00:09:53Z

docs/concepts/services-networking/dns-pod-service.md

+  for more details.
+- "`ClusterFirst`": Any DNS query that does not match the configured cluster
+  domain suffix, such as "`www.kubernetes.io`", is forwarded to the upstream
+  nameserver inherited from the node. Cluster aministrator may have extra


nameserver inherited from the node. Cluster administrators may have extra

zacharysarah · 2017-12-02T00:14:49Z

docs/concepts/services-networking/dns-pod-service.md

 ```

-You should see something like:
+## Compatibility


SIG-docs supports documentation for the current release and the four previous releases. With the release of 1.9, our oldest release would be 1.5.

Is there anything in this section that applies to version compatibility for >1.5? If not, you can safely remove this entire section.

zacharysarah

👋 It looks like Travis is failing due to an error with custom-dns.yaml:

--- FAIL: TestExampleObjectSchemas (0.15s)
	examples_test.go:444: ../docs/concepts/services-networking/custom-dns.yaml did not decode correctly:

Please import the code for busybox.yaml imported by {% include %} as well. 🙇

zacharysarah · 2017-12-03T21:49:56Z

docs/tasks/administer-cluster/dns-custom-nameservers.md

+
+### Create a simple Pod to use as a test environment
+
+Create a file named busybox.yaml with the following contents:


Include this example as an {% include code.html ... %} statement as well, please.

zacharysarah · 2017-12-03T21:54:47Z

docs/concepts/services-networking/custom-dns.yaml

@@ -0,0 +1,20 @@
+apiVersion: v1


Travis is failing and points to this YAML as the reason: https://travis-ci.org/kubernetes/website/builds/310360212?utm_source=github_status&utm_medium=notification

The code validates correctly (and even lints well!), so I'm not sure what's going on. The {% include %} statement that invokes it likewise appears correct. @chenopis, any insight?

@chenopis The Travis build: https://travis-ci.org/kubernetes/website/builds/310360212?utm_source=github_status&utm_medium=notification

zacharysarah · 2017-12-04T04:59:59Z

LGTM 👍

* Trivial change to open release branch * Undo trivial change * add service ipvs overview * Add instructions on how to setup kubectl * Document conntrack dependency for kube-proxy * Add an a This is kind of jarring / missing an article. I'm guessing it should either be ' to a rack of bare metal servers.' or '...to racks of bare metal servers.'. * adding example responses for common issues - support request - code bug report * Trivial change to open release branch * Undo trivial change * Signed-off-by: Ziqi Zhao <zhaoziqi@qiniu.com> (#5366) Fix the not-working test case yaml for /doc/concepts/storage/volumes.md * kubectl-overview * temp fix for broken pod and deployment links * Update Table of Solutions for Juju * Revise certificates documentation (#5965) * Update review-issues.md Some edits for clarity and condensed language. * Update init-containers.md Fix leading spaces in commands. * Update kubectl-overview.md Fix format. * Update clc.md Fix format. * Update openstack-heat.md The url no need. just highlight. * Typo I believe this should be "users" not "uses" * making explicit hostname uniq requirement * Update scheduling-hugepages.md * Update update-daemon-set.md * fix redirection of PersistentVolume * Update hpa.md * update kubectl instruction * Use the format of kubeadm init * fix spelling error guarnatees to guarantees * add matchLabels description (#6020) * search and replace for k8s.github.io to website (#6019) * fix scale command of object-management (#6011) * Update replicaset.md (#6009) * Update secret.md (#6008) * specify password for mysql image (#5990) * specify password for mysql image * specify password for mysql image * link error for run-stateless-application-deployment.md (#5985) * link error for run-stateless-application-deployment.md * link error for run-stateless-application-deployment.md * Add performance implications of inter-pod affinity/anti-affinity (#5979) * 404 monthly maintenance - October 2017 (#5977) * Updated redirects * More redirects * Add conjure-up to Turnkey Cloud Solutions list (#5973) * Add conjure-up to Turnkey Cloud Solutions list * Changed wording slightly * change the StatefulSet to ReplicaSet in reference (#5968) * Clarification of failureThreshold of probes (#5963) * Mention usage of block storage version param (#5925) Mention usage of block storage version (bs-version) parameter to workaround attachment issues using older K8S versions on an OpenStack cloud with path-based endpoints. Resolves: #5924 * Update sysctl-cluster.md (#5894) Include guide on enabling unsafe sysctls in minikube * Avoid Latin phrases & format note (#5889) * Avoid Latin phrases & format note according the Documentation Style Guide * Update scratch.md * Update scratch.md * resolves jekyll rendering error (#5976) - chinese isn't understood for keys in YAML frontmatter in jekyll, so replaced it with the english equivalent that doesn't throw the following error on rendering: Error reading file src/kubernetes.github.io/cn/docs/concepts/cluster-administration/device-plugins.md: (<unknown>): could not find expected ':' while scanning a simple key at line 4 column 1 * Change VM to pod. (#6022) * Add link to custom metrics. (#6023) * Rephrase core group. (#6024) * Added explanation on context to when joining (#6018) * Update create-cluster-kubeadm.md (#5761) Update Canal version in pod network apply commands * Fixes issue #5620 (#5869) * Fixes issue #5620 Signed-off-by: Brad Topol <btopol@us.ibm.com> * Restructured so that review process is for both current and upcoming releases. Added content describing the use of tech reviewers. * Removed incorrect Kubernetes reviewer link. * Fixed tech reviewer URL to now use website * Update pod-priority-preemption.md fix-wrong-link-to-pod-preemption * pod-security-policy.md: add links to the page about admission plugins. * Adding all files for BlaBlaCar case study (#5857) * Adding all files for BlaBlaCar case study * Update blablacar.html * Fix changed URL for google containers * Add /docs/reference/auto-generated directory * correct the downwardapi redirect * Remove links using "here" * Rename to /docs/reference/generated directory * add Concept template * Change title to just Ingress * Link mistake (#6038) * link mistake * link mistake * skip title check for skip_title_check.txt * skip title check for skip_title_check.txt * remove doesn't exist link. * Fix podpreset task (#5705) * Add a simple pod manifest to pod overview (#5986) * Split PodPreset concept out from task doc (#5984) * Add selector spec description (#5789) * Add selector spec description * Fix selector field explanation * Put orphaned topics in TOC. (#6051) * static-pod example bad format in the final page (#6050) * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * static-pod example bad format in the final page * Fix `backoffLimit` field misplacement (#6042) It should be placed in JobSpec according to: https://github.com/kubernetes/kubernetes/blob/master/api/swagger-spec/batch_v1.json#L1488-L1514 * Update addons.md (#6061) * add info about VMware NSX-T CNI plugin (#5987) * add info about VMware NSX-T CNI plugin Hello, I'm VMware Networking and Security Architect and would like to include short information about our CNI plugin implementation similar to what other vendors did Best regards Emil Gagala * Update networking.md * Update networking.md * Update networking.md * Update: Using universal zsh configuration (#5669) * Update install-kubectl.md Zsh is not only oh-my-zsh, so I added universal configuration for zsh that also can be used in prezto. * fix merge error after rebase * Operating etcd cluster for Kubernetes bad format in the final page (#6056) * Operating etcd cluster for Kubernetes bad format in the final page * Update configure-upgrade-etcd.md * Update configure-upgrade-etcd.md * Usage note and warning tags. (#6053) * Usage note and warning tags. * Update configure-upgrade-etcd.md * Update configure-upgrade-etcd.md * Document jekyll includes snippets * Add jekyll includes to docs home toc - Remove extra kubernetes home in toc * document docker cgroupdriver req (#5937) * Update test blacklists (#6063) * Update toc check blacklist * Update title check blacklist * wip * wip * Fix typo * Document unconfined apparmor profile * Revert "Document the unconfined profile for AppArmor" (#6268) * CRD Validation: remove alpha warning, change enable instructions to (#6066) disable * Documented service annotation for AWS ELB SSL policy * kubeadm: add a note about the new `--print-join-command` flag. This is a new flag for the `kubeadm token create` command. * Add a note to PDB page * Improve Kubeadm reference doc (#6103) * automatically-generated kubeadm reference doc * user-mantained kubeadm reference doc * Documentation for CSIPersistentVolume * change replicaset documentation to use apps/v1 APIs * Update service.md ipvs alpha version -> beta version * Updated Deployment concept docs (#6494) * Updated Deployment concept docs * Addressed comments * Documentation for volume scheduling alpha feature * Update admission control docs for webhooks * Improve DNS documentation (#6479) * update ds for 1.9 * Update service.md * Update service.md * Revert "begin updating webhook documentation" (#6575) * Update version numbers to include 1.9 (#6518) * Update site versions for 1.9 * Removed 1.4 docs * Update _config.yml * Update _config.yml * updates for raw block devices * rbac: docs for aggregated cluster roles (#6474) * Added IPv6 information for Kubelet arguments (#6498) * Added IPv6 info to kube-proxy arguments * Added IPv6 information for argument for kubelet * Update PVC resizing documentation (#6487) * Updates for Windows Server version 1709 with K8s v1.8 (#6180) * Updated for WSv1709 and K8s v1.8 * Updated picture and CNI config * Fixed formatting on CNI Config * Updated docs to reference Microsoft/SDN GitHub docs * fix typo * Workaround for Jekyllr frontmatter * Added section on features and limitations, with example yaml files. * Update index.md * Added kubeadm section, few other small fixes * Few minor grammar fixes * Update access-cluster.md with a comment that for IPv6 the user should use [::1] for the localhost * Addressed a number of issues brought up against the base PR * Fixed windows-host-setup link * Rewrite PodSecurityPolicy guide * Update index.md Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> * Spelling correction and sentence capitalization. - Corrected the spelling error for storing, was put in as 'stoing'. - Capitalized list items. - Added '.' at end of sentences in the list items. * Update index.md * Update index.md * Addressed comments and rebased * Fixed formatting * Fixed formatting * Updated header link * Updated hyperlinks * Updated warning * formatting * formatting * formatting * Revert "Update access-cluster.md with a comment that for IPv6" This reverts commit 31e4dbd. * Revert "fix typo" This reverts commit c056787. * Revert "Workaround for Jekyllr frontmatter" This reverts commit b84ac59. * Fixed grammatical issues and reverted non-related commits * Revert "Rewrite PodSecurityPolicy guide" This reverts commit 5d39cfe. * Revert "Spelling correction and sentence capitalization." This reverts commit 47eed43. * Fixed auto-numbering * Minor formatting updates * CoreDNS feature documentation (#6463) * Initial placeholder PR for CoreDNS feature documentation * Remove from admin, add content * Fix missing endcapture * Add to tasks.yml * Review feedback * Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod (#6415) * Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod A new feature PVC Protection was added into K8s 1.9 that's why this documentation change is needed. * Added tag at the top of each new area. * Fix typo * Fix: switched on in (all kubelets) -> (all K8s components). * Added link to admission controller * Moved PVC Protection configuration into Before you begin section. * Added steps how to verify PVC Protection feature. * Fixes for admission controller plugin description and for PVC Protection description in PVC lifecycle. * Testing official rendering of enumerations (1., 2., 3., etc.) * Re-write to address comments from review. * Fixed definition when a PVC is in active use by a pod. * Change auditing docs page for 1.9 release (#6427) * Change auditing docs page for 1.9 release Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Address review comments Signed-off-by: Mik Vyatskov <vmik@google.com> * Fix broken link Signed-off-by: Mik Vyatskov <vmik@google.com> * short circuit deny docs (#6536) * line wrap * short circuit deny * address comments * Add kubeadm 1.9 upgrade docs (#6485) * kubeadm: Improve kubeadm documentation for v1.9 (#6645) * Update admission control docs for webhooks (re-send #6368) (#6650) * Update admission control docs for webhooks * update in response to comments * Revamp rkt and add CRI-O as alternative runtime (#6371) Signed-off-by: Lorenzo Fontana <lo@linux.com> * Documented NLB for Kubernetes 1.9 (#6260) * Added IPV6 information to setup cluster using kubeadm (#6465) * Added IPV6 information to setup cluster using kubeadm * Updated kubeadm.md & create-cluster-kubeadm.md with IPv6 related information * Added IPv6 options for kubeadm --init & automated address binding for kube-proxy based on version of IP configured for API server) * Changes to kubeadm.md as per comments * Modified kubeadm.md and create-cluster-kubeadm.md * Implemented changes requested by zacharysarah * Removed autogenerated kubeadm.md changes * StatefulSet 1.9 updates. (#6550) * updates sts concept and tutorials to use 1.9 apps/v1 * Update statefulset.md * clarify pod name label * Garbage collection updates for 1.9 (#6555) * 1.9 gc policy update * carify deletion * Couple nits for dnsConfig doc (#6652) * Add doc for AllowedFlexVolume (#6563) * Update OpenStack Cloud Provider API support for v1.9 (#6638) * Flex volume is GA. Remove alpha notation. (#6666) * Update generated ref docs for Kubernetes and Federation components. (#6658) * Update generated ref docs for Kubernetes and Federation components. * Rename kubectl-options to kubectl. * Add title to kubectl. * Fix double synopsis. * Update Federation API ref docs for 1.9. (#6636) * Update federation API ref docs. * Move and redirect. * Move generated Federation docs to the generated directory. * Fix titles. * Type * Fix titles * Update auto-generated Kubernetes APi ref docs. (#6646) * Update kubectl commands for 1.9 (#6635) * add ExtendedResourceToleration admission controller (#6618) * Update API reference paths for v1.9 (#6681)

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 29, 2017

k8s-ci-robot assigned steveperry-53 Nov 29, 2017

tengqm mentioned this pull request Nov 29, 2017

Improve DNS documentation #6441

Closed

tengqm mentioned this pull request Nov 29, 2017

[WIP] Documentation for custom pod DNS alpha feature #6408

Closed

k8s-ci-robot assigned MrHohn Nov 29, 2017

steveperry-53 added Needs Docs Review labels Nov 29, 2017

MrHohn reviewed Nov 30, 2017

View reviewed changes

tengqm force-pushed the dns-policy branch from 76d63e2 to 0d67f4e Compare November 30, 2017 08:31

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2017

zacharysarah mentioned this pull request Nov 30, 2017

Release 1.9 #5978

Merged

MrHohn reviewed Nov 30, 2017

View reviewed changes

tengqm force-pushed the dns-policy branch from 0d67f4e to 207f577 Compare December 1, 2017 01:03

MrHohn reviewed Dec 1, 2017

View reviewed changes

zacharysarah suggested changes Dec 2, 2017

View reviewed changes

zacharysarah added Docs Review: Open Issues and removed Needs Docs Review labels Dec 2, 2017

tengqm force-pushed the dns-policy branch from 207f577 to 4db8683 Compare December 2, 2017 03:17

zacharysarah suggested changes Dec 3, 2017

View reviewed changes

tengqm force-pushed the dns-policy branch from 4db8683 to 962b116 Compare December 4, 2017 01:38

Improve DNS documentation

e371c31

tengqm force-pushed the dns-policy branch from 962b116 to e371c31 Compare December 4, 2017 02:33

zacharysarah merged commit b437353 into kubernetes:release-1.9 Dec 4, 2017

zacharysarah mentioned this pull request Dec 7, 2017

[1.9] Issue Burndown kubernetes/sig-release#38

Closed

rohitagarwal003 mentioned this pull request Dec 11, 2017

Remove old annotations from the kube-dns documentation. #6643

Closed

tengqm deleted the dns-policy branch December 25, 2017 04:01

		property will be merged to the options generated from the specified DNS policy.
		Duplicate entries are removed.

		## References

		- [Docs for the DNS cluster addon](http://releases.k8s.io/{{page.githubbranch}}/cluster/addons/dns/README.md)


		The following is an example Pod with custom DNS settings:

		{% include code.html language="yaml" file="ingress.yaml" ghlink="/docs/concepts/services-networking/custom-dns.yaml" %}


		### Create a simple Pod to use as a test environment

		Create a file named busybox.yaml with the following contents:

Improve DNS documentation #6479

Improve DNS documentation #6479

Conversation

tengqm commented Nov 29, 2017 • edited by k8s-reviewable Loading

tengqm commented Nov 29, 2017

k8sio-netlify-preview-bot commented Nov 29, 2017 • edited Loading

MrHohn commented Nov 29, 2017

MrHohn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrHohn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrHohn commented Nov 30, 2017

Choose a reason for hiding this comment

zacharysarah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah commented Dec 4, 2017

tengqm commented Nov 29, 2017 •

edited by k8s-reviewable

Loading

k8sio-netlify-preview-bot commented Nov 29, 2017 •

edited

Loading