kubeadm-upgrade.md: include a generated page about 'diff' and adjust notes #8617

neolit123 · 2018-05-18T16:16:30Z

kubeadm-upgrade: include new command kubeadm upgrade diff …

Also:

Include note that this was added in 1.11.
Modify the note about upgrade guidance.

NOTE!!!:

EDIT: @tengqm mentioned that we:

don't have to include generated pages in PRs
the HTML styling issue explained bellow will be fixed (soon)

the generated page kubeadm_upgrade_diff.md does not have HTML formatting like the two other generated pages here - e.g.:
https://github.com/kubernetes/website/blob/master/content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_upgrade_apply.md.

logged issue about the above:
#8723

k8sio-netlify-preview-bot · 2018-05-18T16:19:57Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 4d131c3

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b116d34e39e7c6660f2806b

Bradamant3 · 2018-05-23T05:32:32Z

/assign

Bradamant3 · 2018-05-23T13:09:26Z

Will dig into scripts for generating. @steveperry-53 seems like I've seen related PRs? Do you have any idea what's going on here?

neolit123 · 2018-05-23T13:15:40Z

@Bradamant3
thanks a lot.

this is a bit of a blocker because me and @chuckha need to document some new kubadm commands and they need this missing HTML styling. we don't want to add it by hand.

Bradamant3 · 2018-05-23T19:59:01Z

Turns out the nice tables were generated locally. We're waiting on a PR merge, here: kubernetes-sigs/reference-docs#47

I've just tagged pwittrock there, and will continue to monitor. If y'all have ideas about how to get that PR merged (I have not got write access to the repo; I'm not even in the org), that would help.

neolit123 · 2018-05-24T13:55:03Z

Turns out the nice tables were generated locally. We're waiting on a PR merge, here: kubernetes-sigs/reference-docs#47

that's a big PR if i've seen one - 21 thousand files.
is there a tool somewhere in there that is used for the nice tables?

if the nice tables were generated locally by a contributor and cannot be reproduced by others, perhaps this styling shouldn't have been accepted in MD files at the website repo before this PR got merged...

I've just tagged pwittrock there, and will continue to monitor. If y'all have ideas about how to get that PR merged (I have not got write access to the repo; I'm not even in the org), that would help.

yes, me too; i don't have powers in that org / repo.
i see that Lucas has powers there and this does affect kubeadm, yet i think this should be addressed to others.

mdlinville · 2018-05-24T22:54:18Z

/lgtm

@Bradamant3 @chenopis @neolit123 PTAL again and someone approve if this still looks good to you.

This does not look like a "new feature" to me, but if it is, @neolit123 please add it to the 1.11 feature tracking spreadsheet.

neolit123 · 2018-05-24T23:41:38Z

This does not look like a "new feature" to me, but if it is, @neolit123 please add it to the 1.11 feature tracking spreadsheet.

i don't really know.
to my understanding this is something that has a release note but it's not a new feature in the k8s sense (alpha, beta...etc stages):
kubernetes/kubernetes#63930

LMK, if it has to be added to the sheet.

mdlinville · 2018-05-24T23:44:46Z

@justaugustus @idvoretskyi PTAL

tengqm · 2018-05-25T14:07:43Z

config.toml

@@ -50,7 +50,7 @@ latest = "v1.11"
 fullversion = "v1.11.0"
 version = "v1.11"
 githubbranch = "master"
-docsbranch = "release-1.11"
+docsbranch = "master"


what does this mean?

i didn't add that. the only commit i did was 1c08038

there seems to be some rebase action going on here.

@Bradamant3 can you verify how this should be? I'm afraid I might have made a mistake when I had to rebase this.

@mistyhacks i will rebase locally and only push my commit again.
also add the changes that @tengqm requested.

tengqm · 2018-05-25T14:09:47Z

content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_upgrade_diff.md

@@ -0,0 +1,38 @@
+


Please wait for the doc generator issue to be fixed. This 1.11 branch won't get published any soon so it is not an urgent problem. If you have believe there are issues to be fixed in the doc content, please raise it to kubeadm source repo.

we have issues for everything in the kubernetes/kubeadm repo. i was told by the kubeadm maintainers to start submitting PRs for these new kubeadm commands which implies including them (< include ...).

why isn't the 1.11 branch of website going to be merged at release?

tengqm · 2018-05-25T14:10:46Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade.md

@@ -33,6 +33,9 @@ Please check these documents out for more detailed how-to-upgrade guidance:
 ## kubeadm upgrade apply  {#cmd-upgrade-apply}
 {{< include "generated/kubeadm_upgrade_apply.md" >}}

+## kubeadm upgrade diff {#cmd-upgrade-diff}
+{{< include "generated/kubeadm_upgrade_diff.md" >}}


Em .... this is important. Even if the reference docs get regenerated, we will still need to manually edit this file.

does that mean - editing the HTML styling by hand?

@tengqm can you clarify please? We should not be manually editing any generated docs files.

@Bradamant3 The file in question (content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade.md) is not generated from tools, the referenced file (e.g. "generated/kubeadm_upgrade_diff.md") is.

neolit123 · 2018-05-25T20:51:07Z

@mistyhacks @Bradamant3 @tengqm
updated.

mdlinville · 2018-05-25T20:58:57Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade.md

@@ -17,7 +17,7 @@ cluster if necessary.
 ## kubeadm upgrade guidance

 Every upgrade process might be a bit different, so we've documented each minor upgrade process individually.
-Please check these documents out for more detailed how-to-upgrade guidance:
+For more detailed how-to-upgrade guidance for each version, see the following resources:


Suggest rewrite: "For more version-specific upgrade guidance, see the following resources:"

@Bradamant3 did that change. do you want me to amend it?

@neolit123 a better editor than I is shepherding the whole 1.11 release. If you wouldn't mind changing it, their version is better. misty and I are meeting soon to make sure we don't inflict colliding edits on any more files for you. My apologies!

hi, i just pushed a change for this.
thanks.

Bradamant3 · 2018-05-25T23:43:32Z

In case it's helpful -- there is a new command for kubeadm, per the linked k/k PR. So there is a new feature, but it's not a whole Big New Feature. (From what I've seen of previous releases, features listed on the spreadsheet often stay in the same stage of things, that is alpha | beta anyway, from one release to the next, while things are polished or improved or added to.)

We need to get the generated docs issue straightened out as soon as possible. I'll comment in the PR for the tooling also. We do need the generated doc so we can check the diffs when strings for docs change in k/k code, but if the format is different then the diffs are useless. I'll think some more about what to do in the meantime. For now, I guess, don't include the generated files in the PRs. But if you could hold off on any more PRs that refer to generated files for a few days (as much as a week? Would that work?), let's see what we can work out.

neolit123 · 2018-05-25T23:59:03Z

In case it's helpful -- there is a new command for kubeadm, per the linked k/k PR. So there is a new feature, but it's not a whole Big New Feature. (From what I've seen of previous releases, features listed on the spreadsheet often stay in the same stage of things, that is alpha | beta anyway, from one release to the next, while things are polished or improved or added to.)

yes, technically these are new features, but not features in the kubernetes/features sense.
we (sig-cluster-lifecycle) are adding like 4 new sub-commands to kubeadm for 1.11 and the maintainers wanted me to document them.

We need to get the generated docs issue straightened out as soon as possible. I'll comment in the PR for the tooling also. We do need the generated doc so we can check the diffs when strings for docs change in k/k code, but if the format is different then the diffs are useless. I'll think some more about what to do in the meantime. For now, I guess, don't include the generated files in the PRs. But if you could hold off on any more PRs that refer to generated files for a few days (as much as a week? Would that work?), let's see what we can work out.

yes, it's also not possible for sig-docs to review the generated files if we add the includes for them, but not the actual generated files in a PR. i will hold on sending more command PRs for now.
thanks.

steveperry-53 · 2018-06-01T05:14:10Z

kubernetes-sigs/reference-docs#47 is merged now.

neolit123 · 2018-06-01T13:17:47Z

yesterday, we spoke with @Bradamant3 and also according to what @tengqm is stating, this PR is good to be merged.
the generated / included .MD will come from the tooling.

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

neolit123 · 2018-06-01T15:59:37Z

rebased against 1.11.

Bradamant3 · 2018-06-01T16:35:55Z

/lgtm

mdlinville · 2018-06-01T16:36:25Z

/approve

k8s-ci-robot · 2018-06-01T16:36:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

steveperry-53 · 2018-06-01T22:50:40Z

Hmm, I must be missing something. This was merged into the release-1.11 branch, correct? Then why don't we see the change at either of theses places?

I'm talking about this change: "In Kubernetes v1.11.0 and later, you can use kubeadm upgrade diff to see ..."

neolit123 · 2018-06-01T23:00:22Z

@steveperry-53
i can see the include for the diff command in the second link, but not in the first one.
both links are missing the In Kubernetes v1.11.0 and later... note.

could be that the note was added later in an amended commit and the tooling did not re-generate a new preview for that.

steveperry-53 · 2018-06-01T23:05:02Z

Let's keep an eye on this. It's especially important that we get a good 1.11 preview here:

http://kubernetes-io-vnext-staging.netlify.com/docs/reference/setup-tools/kubeadm/kubeadm-upgrade/

neolit123 · 2018-06-01T23:09:51Z

Let's keep an eye on this

i would ping the preview generation maintainer about this.
the problem can propagate to other RPs.

Bradamant3 · 2018-06-02T12:57:10Z

All Netlify deploys have been failing for a while. I've got a fix in mind, but want to take a real weekend, so I'll fiddle with it on Monday.

…es#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2018

k8s-ci-robot requested review from bradtopol and xiangpengzhao May 18, 2018 16:16

neolit123 changed the title ~~kubeadm-upgrade: add generated page and include about 'diff'~~ kubeadm-upgrade: add generated page and include for 'diff' May 18, 2018

neolit123 mentioned this pull request May 21, 2018

Generate documentation automatically from our external API types and CLI commands kubernetes/kubeadm#842

Closed

Bradamant3 added this to the 1.11 milestone May 23, 2018

k8s-ci-robot assigned Bradamant3 May 23, 2018

mdlinville force-pushed the release-1.11 branch from 5647835 to 8594900 Compare May 24, 2018 20:43

mdlinville force-pushed the kubeadm-upgrade-diff branch from d365d82 to 091502f Compare May 24, 2018 22:52

k8s-ci-robot assigned mdlinville May 24, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018

tengqm reviewed May 25, 2018

View reviewed changes

neolit123 force-pushed the kubeadm-upgrade-diff branch from 091502f to 2fe2145 Compare May 25, 2018 20:48

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2018

neolit123 changed the title ~~kubeadm-upgrade: add generated page and include for 'diff'~~ kubeadm-upgrade.md: include a generated page and adjust note about upgrade guides May 25, 2018

neolit123 changed the title ~~kubeadm-upgrade.md: include a generated page and adjust note about upgrade guides~~ kubeadm-upgrade.md: include a generated page about 'diff' and adjust notes May 25, 2018

mdlinville reviewed May 25, 2018

View reviewed changes

Bradamant3 mentioned this pull request May 25, 2018

Add support to generate reference docs for kube components kubernetes-sigs/reference-docs#47

Merged

neolit123 force-pushed the kubeadm-upgrade-diff branch from 2fe2145 to 0c37433 Compare May 26, 2018 11:22

zacharysarah added the Docs Review: Open Issues label May 31, 2018

kubeadm-upgrade: include new command kubeadm upgrade diff

4d131c3

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

neolit123 force-pushed the kubeadm-upgrade-diff branch from 0c37433 to 4d131c3 Compare June 1, 2018 15:58

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2018

k8s-ci-robot merged commit 89ecc29 into kubernetes:release-1.11 Jun 1, 2018

neolit123 mentioned this pull request Jun 1, 2018

document kubeadm upgrade diff at website kubernetes/kubeadm#832

Closed

k82cn pushed a commit to k82cn/website that referenced this pull request Jun 11, 2018

kubeadm-upgrade: include new command kubeadm upgrade diff (kubernet…

6371c1f

…es#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

mdlinville pushed a commit that referenced this pull request Jun 20, 2018

kubeadm-upgrade: include new command kubeadm upgrade diff (#8617)

c371c50

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

kubeadm-upgrade: include new command kubeadm upgrade diff (#8617)

d56516d

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

kubeadm-upgrade: include new command kubeadm upgrade diff (#8617)

f57085d

Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance.

lucperkins mentioned this pull request Jul 6, 2018

Generated kubeadm docs for 1.11 are inconsistently formatted during release cycle #8723

Closed

2 tasks

kubeadm-upgrade.md: include a generated page about 'diff' and adjust notes #8617

kubeadm-upgrade.md: include a generated page about 'diff' and adjust notes #8617

Conversation

neolit123 commented May 18, 2018 • edited Loading

NOTE!!!:

k8sio-netlify-preview-bot commented May 18, 2018 • edited Loading

Bradamant3 commented May 23, 2018

Bradamant3 commented May 23, 2018

neolit123 commented May 23, 2018

Bradamant3 commented May 23, 2018

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 May 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented May 25, 2018

Choose a reason for hiding this comment

neolit123 May 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bradamant3 commented May 25, 2018

neolit123 commented May 25, 2018

steveperry-53 commented Jun 1, 2018

neolit123 commented Jun 1, 2018

neolit123 commented Jun 1, 2018

Bradamant3 commented Jun 1, 2018

mdlinville commented Jun 1, 2018

k8s-ci-robot commented Jun 1, 2018

steveperry-53 commented Jun 1, 2018

neolit123 commented Jun 1, 2018

steveperry-53 commented Jun 1, 2018

neolit123 commented Jun 1, 2018

Bradamant3 commented Jun 2, 2018

neolit123 commented May 18, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 18, 2018 •

edited

Loading

neolit123 May 25, 2018 •

edited

Loading

neolit123 May 25, 2018 •

edited

Loading