kubeadm-config: include new commands #8862

neolit123 · 2018-06-01T15:46:29Z

Add notes and includes for these new commands in 1.11:

kubeadm config print-default
kubeadm config migrate
kubeadm config images list
kubeadm config images pull

Include placeholder generated files for the above.

/assign @Bradamant3
@kubernetes/sig-cluster-lifecycle-pr-reviews

Fixes kubernetes/kubeadm#873
Fixes kubernetes/kubeadm#831
Fixes kubernetes/kubeadm#880

k8sio-netlify-preview-bot · 2018-06-01T15:46:32Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 0d4ca37

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b1e72eab13fb1076a5b4ff2

detiber · 2018-06-04T15:16:12Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-config.md

@@ -16,6 +16,10 @@ You can execute `kubeadm config view` to view the ConfigMap. If you initialized
 kubeadm v1.7.x or lower, you must use `kubeadm config upload` to create the ConfigMap before you
 may use `kubeadm upgrade`.

+In Kubernetes v1.11.0, a couple of new commands were added - `kubeadm config print-default`
+and `kubeadm config migrate`. You can use `kubeadm config print-default` to print the default
+configuration and `kubeadm config migrate` to convert your old configuratin files to a newer version.


s/old configuratin/old configuration/

Bradamant3 · 2018-06-04T15:35:51Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-config.md

@@ -27,6 +31,12 @@ may use `kubeadm upgrade`.

 ## kubeadm config view {#cmd-config-view}
 {{< include "generated/kubeadm_config_view.md" >}}
+
+## kubeadm config print-default {#cmd-config-print-defaalt}


s/defaalt/default

Bradamant3

As we discussed on Slack, we need to add either placeholder files or the actual generated files before we can merge this PR, to avoid docs build breaks.

Bradamant3 · 2018-06-04T15:36:58Z

/hold

mdlinville · 2018-06-04T18:31:59Z

This needs to be rebased to resolve merge conflicts, and I do not have permission to do so on your behalf.

neolit123 · 2018-06-04T18:59:53Z

@Bradamant3 @mistyhacks rebased + updated.

neolit123 · 2018-06-04T23:49:31Z

included 2 more commands for kubeadm config.

Bradamant3 · 2018-06-05T11:35:23Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-config.md

+to print the default configuration and `kubeadm config migrate` to convert your old configuration
+files to a newer version. `kubeadm config images list` and `kubeadm config images pull` can be used
+to to list and pull the images which kubeadm requires.
+


Sorry, I should have caught this on first review. Remove extra "to" on line 22.

But also -- do we need most of this content (ll19-22)? Hugo automatically generates a TOC list of all the commands based on their headings (see the Netlify preview). Does it help the user to know which ones are new at the top of the file? If so, do they need a summary of what they do when the names indicate pretty clearly what they do? I am not really sure how to make this work nicely with Hugo, will dig later.

@Bradamant3

thanks for spotting that typo,
so the user knowing that new commands are added (i.e. like in a "what's new" section) is definitely a great plus. i really do not know how this can be done automatically with Hugo, but please let me know if you want me to remove the above notes.

i will wait on your decision before submitting the typo fix.

Let's just fix the typo, and ponder alternatives to the list of new things another time. If I come up with a clever idea in time, I'll submit a follow-on PR.

@Bradamant3 ACK.

Bradamant3 · 2018-06-05T11:36:45Z

@neolit123 sorry, I missed one necessary editorial fix. Also added a usability question that's not a blocker -- would appreciate your thoughts on it, but I won't hold up merging bc of it.

neolit123 · 2018-06-06T22:48:05Z

@Bradamant3 done, typo fixed.
(+rebased)

mdlinville · 2018-06-06T22:53:31Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-config.md

+In Kubernetes v1.11.0, some new commands were added. You can use `kubeadm config print-default`
+to print the default configuration and `kubeadm config migrate` to convert your old configuration
+files to a newer version. `kubeadm config images list` and `kubeadm config images pull` can be used
+to list and pull the images which kubeadm requires.


s/which/that since kubeadm isn't a person :)

neolit123 · 2018-06-06T22:57:37Z

@mistyhacks @Bradamant3 updated again.
i'm going to finally learn proper english in these parts...har, har. :)

Bradamant3 · 2018-06-07T12:43:31Z

/hold cancel
/approve for docs review

leaving lgtm for Misty bc we've been through a few rounds on this one.

Bradamant3 · 2018-06-07T12:45:05Z

hrm

/hold cancel

Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above.

k8s-ci-robot · 2018-06-11T13:02:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

neolit123 · 2018-06-11T13:02:59Z

rebased for easy merge.
@mistyhacks LGTY?

Bradamant3 · 2018-06-11T13:24:26Z

we need to get merged.

/lgtm

neolit123 · 2018-06-11T13:27:00Z

thanks!

Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above.

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot assigned Bradamant3 Jun 1, 2018

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2018

k8s-ci-robot requested review from luxas and mikedanese June 1, 2018 15:46

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2018

This was referenced Jun 1, 2018

document "kubeadm config migrate" kubernetes/kubeadm#873

Closed

document kubeadm config print-default at website kubernetes/kubeadm#831

Closed

Bradamant3 added this to the 1.11 milestone Jun 1, 2018

neolit123 mentioned this pull request Jun 1, 2018

Umbrella: 1.11 kubeadm tracking issue #8846

Closed

detiber reviewed Jun 4, 2018

View reviewed changes

Bradamant3 reviewed Jun 4, 2018

View reviewed changes

Bradamant3 suggested changes Jun 4, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2018

mdlinville force-pushed the release-1.11 branch from 4b3430b to 7549d77 Compare June 4, 2018 17:24

neolit123 force-pushed the kubeadm-config branch from 3631245 to fc47feb Compare June 4, 2018 18:54

neolit123 force-pushed the kubeadm-config branch from fc47feb to 601f8c6 Compare June 4, 2018 23:47

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2018

neolit123 mentioned this pull request Jun 4, 2018

document "kubeadm config images *" kubernetes/kubeadm#880

Closed

neolit123 force-pushed the kubeadm-config branch from 601f8c6 to 980ecb7 Compare June 4, 2018 23:54

Bradamant3 reviewed Jun 5, 2018

View reviewed changes

neolit123 force-pushed the kubeadm-config branch from 980ecb7 to 432cdb7 Compare June 6, 2018 22:47

mdlinville reviewed Jun 6, 2018

View reviewed changes

neolit123 force-pushed the kubeadm-config branch from 432cdb7 to 64a6e48 Compare June 6, 2018 22:56

Bradamant3 approved these changes Jun 7, 2018

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2018

kubeadm-config: include new commands

0d4ca37

Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above.

neolit123 force-pushed the kubeadm-config branch from 64a6e48 to 0d4ca37 Compare June 11, 2018 13:02

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018

k8s-ci-robot merged commit af14315 into kubernetes:release-1.11 Jun 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm-config: include new commands #8862

kubeadm-config: include new commands #8862

neolit123 commented Jun 1, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Jun 1, 2018 •

edited

Loading

detiber Jun 4, 2018

Bradamant3 Jun 4, 2018

Bradamant3 left a comment

Bradamant3 commented Jun 4, 2018

mdlinville commented Jun 4, 2018

neolit123 commented Jun 4, 2018

neolit123 commented Jun 4, 2018

Bradamant3 Jun 5, 2018

neolit123 Jun 5, 2018 •

edited

Loading

Bradamant3 Jun 6, 2018 •

edited

Loading

neolit123 Jun 6, 2018

Bradamant3 commented Jun 5, 2018

neolit123 commented Jun 6, 2018

mdlinville Jun 6, 2018

neolit123 commented Jun 6, 2018 •

edited

Loading

Bradamant3 commented Jun 7, 2018 •

edited

Loading

Bradamant3 commented Jun 7, 2018

k8s-ci-robot commented Jun 11, 2018

neolit123 commented Jun 11, 2018

Bradamant3 commented Jun 11, 2018

neolit123 commented Jun 11, 2018

kubeadm-config: include new commands #8862

kubeadm-config: include new commands #8862

Conversation

neolit123 commented Jun 1, 2018 • edited Loading

k8sio-netlify-preview-bot commented Jun 1, 2018 • edited Loading

detiber Jun 4, 2018

Choose a reason for hiding this comment

Bradamant3 Jun 4, 2018

Choose a reason for hiding this comment

Bradamant3 left a comment

Choose a reason for hiding this comment

Bradamant3 commented Jun 4, 2018

mdlinville commented Jun 4, 2018

neolit123 commented Jun 4, 2018

neolit123 commented Jun 4, 2018

Bradamant3 Jun 5, 2018

Choose a reason for hiding this comment

neolit123 Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Bradamant3 Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

neolit123 Jun 6, 2018

Choose a reason for hiding this comment

Bradamant3 commented Jun 5, 2018

neolit123 commented Jun 6, 2018

mdlinville Jun 6, 2018

Choose a reason for hiding this comment

neolit123 commented Jun 6, 2018 • edited Loading

Bradamant3 commented Jun 7, 2018 • edited Loading

Bradamant3 commented Jun 7, 2018

k8s-ci-robot commented Jun 11, 2018

neolit123 commented Jun 11, 2018

Bradamant3 commented Jun 11, 2018

neolit123 commented Jun 11, 2018

neolit123 commented Jun 1, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Jun 1, 2018 •

edited

Loading

neolit123 Jun 5, 2018 •

edited

Loading

Bradamant3 Jun 6, 2018 •

edited

Loading

neolit123 commented Jun 6, 2018 •

edited

Loading

Bradamant3 commented Jun 7, 2018 •

edited

Loading