Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New BotKube command to list the supported kubectl cmds #312

Closed
PrasadG193 opened this issue Jul 22, 2020 · 0 comments · Fixed by #328
Closed

New BotKube command to list the supported kubectl cmds #312

PrasadG193 opened this issue Jul 22, 2020 · 0 comments · Fixed by #328
Assignees
@girishg4t
Labels
enhancement New feature or request good first issue Good for newcomers release-blocker Upcoming release is blocked by this issue

Comments

@PrasadG193
Copy link
Collaborator

PrasadG193 commented Jul 22, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

Now that we have support to configure allowed kubectl commands, the list of commands documented in /botkubehelp are misleading. There should be a way to let user know what kind of commands are supported.

Describe the solution you'd like

Add new BotKube command - e.g @BotKube commands list to list down all the supported commands.
If settings.kubectl.restrictAccess is not set, the command should be executable from outside channel too.

Additional context
We should be using cobra framework to consolidate all BotKube commands. But can be treated as a different task
@PrasadG193 PrasadG193 added enhancement New feature or request good first issue Good for newcomers labels Jul 22, 2020
@PrasadG193 PrasadG193 changed the title Add new BotKube command to list the supported kubectl cmds New BotKube command to list the supported kubectl cmds Jul 22, 2020
@PrasadG193 PrasadG193 added the release-blocker Upcoming release is blocked by this issue label Aug 3, 2020
@girishg4t girishg4t mentioned this issue Aug 20, 2020
Merged
@mergify mergify bot closed this as completed in #328 Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@girishg4t
Added '@botkube commands list' to show all the supported kubectl cmds (…
ae980c7 
…#328)

##### ISSUE TYPE
 - Feature Pull Request

##### SUMMARY
Added new botkube command to list all the supported commands, @botkube commands list

Below are the changes
made changes in executor.go to handle newly added command  
added common method in utils.go to format the allowed commands  

Fixes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishg4t girishg4t

Labels
enhancement New feature or request good first issue Good for newcomers release-blocker Upcoming release is blocked by this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added '@Botkube commands list' to show all the supported kubectl cmds kubeshop/botkube
2 participants
@PrasadG193 @girishg4t