Added '@Botkube commands list' to show all the supported kubectl cmds #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@girishg4t Could you please add this screenshot of command response here? |
PrasadG193
reviewed
Aug 22, 2020
pkg/execute/executor.go
Outdated
| @@ -146,6 +149,14 @@ const ( | |||
| FilterDisable FiltersAction = "disable" | |||
| ) | |||
|
|
|||
| // InfoAction for options in Info commands | |||
| type InfoAction string | |||
There was a problem hiding this comment.
Let's not export InfoAction type if not needed
There was a problem hiding this comment.
corrected InfoAction to infoAction
There was a problem hiding this comment.
The output of the command is
allowed verbs:
- cluster-info
- diff
- get
- api-resources
- api-versions
- describe
- explain
- logs
- top
- auth
allowed resources:
- storageclasses
- nodes
- deployments
- pods
- namespaces
- daemonsets
- statefulsets
pkg/utils/utils.go
Outdated
| @@ -477,3 +479,15 @@ func GetClusterNameFromKubectlCmd(cmd string) string { | |||
| } | |||
| return s | |||
| } | |||
|
|
|||
| //GetFormatedCommandsList get the formated commands list | |||
| func GetFormatedCommandsList(header string, commands map[string]bool) string { | |||
There was a problem hiding this comment.
Please use generic name for the function. It feels that this func is specifically for command list only
There was a problem hiding this comment.
corrected name to GetStingInYamlFormat, pls suggest
test/e2e/command/botkube.go
Outdated
| @@ -90,6 +115,7 @@ func (c *context) testBotkubeCommand(t *testing.T) { | |||
|
|
|||
| func compareFilters(expected, actual []string) bool { | |||
| if len(expected) != len(actual) { | |||
| log.Infof("************************Expected %d Actual %d", len(expected), len(actual)) | |||
There was a problem hiding this comment.
Please remove the debug logs
girishg4t
changed the title
girishg4t
changed the title
girishg4t
changed the title
PrasadG193
reviewed
Sep 1, 2020
PrasadG193
approved these changes
Sep 2, 2020
PrasadG193
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Added new botkube command to list all the supported commands, @botkube commands list
Below are the changes
made changes in executor.go to handle newly added command
added common method in utils.go to format the allowed commands
Fixes #312