Improve non-interactive messages for ArgoCD source #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
improve-non-interactive
branch
2 times, most recently
from
84456d5
to
293b9bc
Compare
pkosiec
force-pushed
the
improve-non-interactive
branch
from
293b9bc
to
49d4fed
Compare
huseyinbabal
reviewed
Sep 7, 2023
huseyinbabal
reviewed
Sep 7, 2023
| log: | ||
| level: "info" | ||
|
|
||
| interactivity: |
There was a problem hiding this comment.
Maybe it is better add a field description, "Not all the platforms support this. Only Slack for now". Or something relevant.
huseyinbabal
approved these changes
Sep 7, 2023
pkosiec
force-pushed
the
improve-non-interactive
branch
from
efac475
to
ff416c0
Compare
pkosiec
force-pushed
the
improve-non-interactive
branch
from
ff416c0
to
5e21c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
values.yamlScreenshots
FYI they are slightly outdated - I've replaced ✅ icon for "on-app-deployed" to 🚀 , as the same icon was used for "on-successful-sync" trigger.
Mattermost
Discord
Teams
Slack (no change here)
Testing
Follow the same instruction as in #1220, but also configure all other platforms.
Related issue(s)
#1175