-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce interactive ArgoCD source plugin #1220
Conversation
89aa693
to
df52b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 🚀 I have a couple of comments;
- The minor ones on PR
- The buttons beside
get
describe
dropdown seems, they are tightly coupled with dropdown, but actually they are not. For example, I selectedget
and tried to clickDetails
to run actual command, however it is automatically executed once selected. Maybe we can renameDetails
asView in ArgoCD
, but not so important. - Tested on discord too, works great
@huseyinbabal Thank you Huseyin! the button/dropdown layout is the same as in Kubernetes source, so yeah, they are not coupled. Maybe I'll make the primary button a default one? And yes, I'll change labels. Thank you! |
1e9272d
to
3e94d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved with a minor comment
Description
Changes proposed in this pull request:
Questions
Follow-up PRs
Video
Screen.Recording.2023-09-06.at.00.09.36.mp4
(sorry for a long delay when typing admin password - I was looking for it 😅)
BTW just two
kubectl
commands are supported:Testing
Checkout PR:
Build all plugins:
Prepare
comm_config.yaml
:For full options check out
values.yaml
.Apply these RBAC resources:
Details
Go through ArgoCD Getting started doc and install Argo. Do all steps until step 7. Do not sync the app yet.
Run Botkube locally:
After startup, wait for Argo notification. Sync (deploy the app) according to the guide: https://argo-cd.readthedocs.io/en/stable/getting_started/#7-sync-deploy-the-application
Delete the app
Related issue(s)
#1175