Fix ArgoCD template name normalization #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
approved these changes
Sep 8, 2023
pkosiec
added a commit
to pkosiec/botkube
that referenced
this pull request
Sep 11, 2023
- Fix ArgoCD template name normalization - Fix incoming webhook for handling / characters in the source name (cherry picked from commit 1b4e938)
pkosiec
added a commit
that referenced
this pull request
Sep 11, 2023
- Fix ArgoCD template name normalization - Fix incoming webhook for handling / characters in the source name (cherry picked from commit 1b4e938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
/characters in the source nameTesting
Use instruction from #1220, but instead of argocd source config name, try to use something like, e.g.
argocd/BK. Use the name both in Helm chart and the values.yaml for overrides.Related issue(s)
#1175