Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgoCD notification setup and JSON schema #1237

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fix ArgoCD notification setup and JSON schema #1237

merged 3 commits into from
Sep 8, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Sep 7, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix JSON schema for ArgoCD
    • Tested against Botkube Cloud UI
  • Fix not generating Kubeconfig if both mappings are empty
  • Fix normalizing names during ArgoCD notifications setup

Testing

Use instruction from #1220, but instead of argocd source config name, try to use something longer, e.g. my-custom-argocd. Use the name both in Helm chart and the values.yaml for overrides.

Related issues

#1175

@pkosiec pkosiec added the bug Something isn't working label Sep 7, 2023
@pkosiec pkosiec changed the title Fix JSON schema for ArgoCD Fix ArgoCD notification setup and JSON schema Sep 7, 2023
@pkosiec pkosiec marked this pull request as ready for review September 7, 2023 22:28
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners September 7, 2023 22:28
@pkosiec pkosiec requested review from mszostok and huseyinbabal and removed request for mszostok September 7, 2023 22:28
huseyinbabal
huseyinbabal approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🚀
Screenshot 2023-09-08 at 10 47 42
Screenshot 2023-09-08 at 10 48 04
Screenshot 2023-09-08 at 10 48 31

@pkosiec pkosiec merged commit 9d25b59 into kubeshop:main Sep 8, 2023
15 checks passed
@pkosiec pkosiec deleted the fix-schema-display branch September 8, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @huseyinbabal