Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go1.18 #432

Closed
mbana opened this issue May 23, 2022 · 0 comments · Fixed by kubeshop/kusk#40
Closed

Upgrade to go1.18 #432

mbana opened this issue May 23, 2022 · 0 comments · Fixed by kubeshop/kusk#40

Comments

@mbana
Copy link
Contributor

mbana commented May 23, 2022

Describe the enhancement you'd like to see

Why: kubeshop/kusk#37 (review).

We should upgrade to go1.18 by:

  • Modifying all go.mods to use go 1.18.
  • Ensure tooling, goreleaser etc., works with go1.18.

Additional context

The latest stable version of go is go1.18.2. See: https://go.dev/dl/.


This could be a tracking issue for all kusk-* repositories.

mbana pushed a commit to kubeshop/kusk that referenced this issue May 24, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.

Tested with latest stable version, which is `go1.18.2` at the time of writing this.
mbana pushed a commit to kubeshop/kusk that referenced this issue May 24, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.

Tested with latest stable version, which is `go1.18.2` at the time of writing this.
mbana pushed a commit to kubeshop/kusk that referenced this issue May 24, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.

Tested with latest stable version, which is `go1.18.2` at the time of writing this.
mbana pushed a commit that referenced this issue May 24, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.
* Used fully qualified name for image, see: <https://docs.docker.com/registry/introduction/#understanding-image-naming>.
* `Makefile`: Quote `LD_FLAGS`m, see: <https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications> ("single quotes are used to avoid breaking characters in the key-value pair").
mbana pushed a commit that referenced this issue Jun 8, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.
* Used fully qualified name for image, see: <https://docs.docker.com/registry/introduction/#understanding-image-naming>.
* `Makefile`: Quote `LD_FLAGS`m, see: <https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications> ("single quotes are used to avoid breaking characters in the key-value pair").
mbana pushed a commit that referenced this issue Jun 9, 2022
* `go.mod`: Modified to use `go 1.18`, run `go mod download` and `go mod verify`, followed by `make test` and `make build`.
* Tooling versions updated to ones that support `go1.18`.
* Used fully qualified name for image, see: <https://docs.docker.com/registry/introduction/#understanding-image-naming>.
* `Makefile`: Quote `LD_FLAGS`m, see: <https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications> ("single quotes are used to avoid breaking characters in the key-value pair").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant