Kusk CLI version - Partially closes kubeshop/kusk-gateway#415
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References or inspired by ------------------------- * <https://github.com/cli/cli/blob/trunk/pkg/cmd/version/version.go> * <https://github.com/cli/cli/blob/trunk/internal/build/build.go> * <https://github.com/cli/cli/blob/trunk/pkg/cmd/version/version_test.go> * <https://github.com/cli/cli/blob/trunk/pkg/cmd/root/root.go#L75> * <https://github.com/cli/cli/blob/trunk/Makefile> * <https://github.com/cli/cli/blob/trunk/script/build.go> (search for `ldflags`)
mbana
changed the title
Makefile - Partially closes kubeshop/kusk-gateway#418:version - Partially closes kubeshop/kusk-gateway#418
jasmingacic
suggested changes
May 18, 2022
Version information such as tag, revision and build date and time is built at _build_ time without having to resort to using `GO_LDFLAGS` or `-ldflags`, see: `internal/build/build.go`.
I took another approach which is to call |
jasmingacic
suggested changes
May 20, 2022
Define a `version` command that uses value of `github.com/kubeshop/kusk-gateway/pkg/build` populated by `ldflags`: * `github.com/kubeshop/kusk-gateway`: Get latest version that includes `github.com/kubeshop/kusk-gateway/pkg/build` package. * `github.com/kubeshop/kusk-gateway/pkg/build`: `Version` variable will contain the latest tag when built. * `TELEMETRY_TOKEN`: Remove references to `ldflags`/build-arg that is not used. * `.github/workflows/go.yml`: Remove `test-GoReleaser-build` as we can just run it locally using `make build-goreleaser`. * `.goreleaser.yml`: Populate `KuskGAMeasurementID` based on secret/env. * `.goreleaser.yml`: Populate `KuskGAApiSecret` based on secret/env. Example run log --------------- ```sh $ make build Makefile:62: warning: undefined variable 'GA_ID' Makefile:62: warning: undefined variable 'GA_SECRET' go build -v -o ./kusk -ldflags="-X 'github.com/kubeshop/kusk-gateway/pkg/build.Version=v1.0.4-5-ga63345e' -X 'github.com/kubeshop/kusk-gateway/pkg/analytics.KuskGAMeasurementID=' -X 'github.com/kubeshop/kusk-gateway/pkg/analytics.KuskGAApiSecret='" ./main.go $ ./kusk version kusk version 1.0.4-5-ga63345e https://github.com/kubeshop/kusk/releases/latest $ ./kusk --version kusk version 1.0.4-5-ga63345e https://github.com/kubeshop/kusk/releases/latest $ ./kusk -v kusk version 1.0.4-5-ga63345e https://github.com/kubeshop/kusk/releases/latest ```
mbana
changed the title
version - Partially closes kubeshop/kusk-gateway#418version - Partially closes kubeshop/kusk-gateway#415
jasmingacic
approved these changes
May 23, 2022
This is quite risky. Wouldn't it require anyone doing a |
|
I'd ditch go install as an install option |
I can do it as a separate PR ... ? What do you think? |
kylehodgetts
approved these changes
May 23, 2022
…usk-gateway#415 > agreed. Just check if it contains the version Just check the buffer contains the `version` in `Test_NewVersionCommand`.
|
go ahead and merge it |
…usk-gateway#415 `.goreleaser.yml`: Strip binary of debug information (`LD_FLAGS += -w -s`) etc. - reduces the size of final download.
jasmingacic
approved these changes
May 23, 2022
|
Tested with: ./kusk version; ./kusk --version; ./kusk -v
kusk version 1.0.5-rc1
https://github.com/kubeshop/kusk/releases/tag/v1.0.5-rc1
kusk version 1.0.5-rc1
https://github.com/kubeshop/kusk/releases/tag/v1.0.5-rc1
kusk version 1.0.5-rc1
https://github.com/kubeshop/kusk/releases/tag/v1.0.5-rc1Which seems right to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kusk CLI
version- Partially closes kubeshop/kusk-gateway#415Define a
versioncommand that uses value ofgit.luolix.top/kubeshop/kusk-gateway/pkg/buildpopulated byldflags:github.com/kubeshop/kusk-gateway: Get latest version that includesgit.luolix.top/kubeshop/kusk-gateway/pkg/buildpackage.github.com/kubeshop/kusk-gateway/pkg/build:Versionvariable will contain the latest tag when built.TELEMETRY_TOKEN: Remove references toldflags/build-arg that is not used..github/workflows/go.yml: Removetest-GoReleaser-buildas we can just run it locally usingmake build-goreleaser..goreleaser.yml: PopulateKuskGAMeasurementIDbased on secret/env..goreleaser.yml: PopulateKuskGAApiSecretbased on secret/env.Example run log
This PR...
Changes
Fixes
Checklist