Makefile is broken!!!

[jasmingacic]

When ran on a fresh box either a docker container, linux host or macos running make produces this error:

[INFO] Installing protoc compiler to /root/temp/kusk-gateway/bin/protoc
Downloading protoc-3.19.4-linux-x86_64.zip to /tmp/tmp.s45qlzdcpI
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1660k  100 1660k    0     0  3747k      0 --:--:-- --:--:-- --:--:-- 3747k
bash: unzip: command not found
make: *** [Makefile:197: /root/temp/kusk-gateway/bin/protoc/bin/protoc] Error 127

or in some cases

[INFO]: Installing protobuf go generation plugin.
go: creating new go.mod: module tmp
Downloading google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1
go: added google.golang.org/protobuf v1.27.1
[INFO]: Installing protobuf GRPC go generation plugin.
go: creating new go.mod: module tmp
Downloading google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.2.0
go: added google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.2.0
go: added google.golang.org/protobuf v1.27.1
cd "internal/agent/management"; /root/go/src/github.com/kubeshop/kusk-gateway/bin/protoc/bin/protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative *.proto
protoc-gen-go-grpc: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable

[jasmingacic]

And easy way to replicate:

FROM golang
WORKDIR /

RUN git clone https://github.com/kubeshop/kusk-gateway.git

RUN cd kusk-gateway && make 

[mbana]

unzip is required. Please try:

FROM docker.io/library/golang:1.17
WORKDIR /

RUN apt-get update -y
RUN apt-get install -y unzip
RUN git clone https://github.com/kubeshop/kusk-gateway.git

RUN cd kusk-gateway && make

$ docker build -t test . # or `podman build -t test .`
...
go build -o bin/manager -ldflags='-X github.com/kubeshop/kusk-gateway/pkg/analytics.TelemetryToken=' cmd/manager/main.go
go build -o bin/agent -ldflags='-X github.com/kubeshop/kusk-gateway/pkg/analytics.TelemetryToken=' cmd/agent/main.go
Removing intermediate container fe0dcc0009f4
 ---> f91a80b17e7b
Successfully built f91a80b17e7b
Successfully tagged test:latest

[jasmingacic]

This was just an example why it failed I could install unzip but that's not the point.

Two Linux boxes and one Mac can't run make see the rest of the errors.

Even if you install unzip it will produce this error:

[INFO] Installing protoc compiler to /kusk-gateway/bin/protoc
Downloading protoc-3.19.4-linux-x86_64.zip to /tmp/tmp.lN50fZp9Nw
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1660k  100 1660k    0     0  3608k      0 --:--:-- --:--:-- --:--:-- 3608k
Archive:  protoc-3.19.4-linux-x86_64.zip
checkdir:  cannot create extraction directory: /kusk-gateway/bin/protoc
           No such file or directory
make: *** [Makefile:197: /kusk-gateway/bin/protoc/bin/protoc] Error 2
The command '/bin/sh -c cd kusk-gateway && make' returned a non-zero code: 2