-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Cleanup Makefile
- Closes kubeshop/kusk-gateway#418
#419
Conversation
✅ Deploy Preview for kusk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments made above
Do you think it's also worth adding a test into the CI to make sure this doesn't break again unexpectedly?
Thanks. Yes. What particular type of tests do you have in mind? In a separate PR or this one? Actually, the reason I wanted folks to try out my branch was to be sure I hadn't broken anything. I am going to test further before we even get to merge state. |
If possible add consistent test even though CI should detect it |
A separate PR. on build before merge to master
|
works with go 1.18 both on MacOS and Ubuntu |
* Replace `go get` with `go install` in `Makefile`. * Tidy up `Makefile`. * Introduce `tools` in `Makefile` that downloads all the tools/dependencies required. * `DOCKER_BUILDKIT`: No point in defining this everyone - exporting and defining should be enough. For further information, see: * kubernetes-sigs/kubebuilder#2566 * kubernetes-sigs/kubebuilder#2486
1. > The indentation for these variable assignments are a bit all over the place, can you align them, please? 2. > If you've tested that kustomize v4 works as expected, this comment can be removed Closes #418
4d8239f
to
85539c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Fix/Cleanup
Makefile
- Closes #418:go get
withgo install
inMakefile
.Makefile
.tools
inMakefile
that downloads all the tools/dependencies required.DOCKER_BUILDKIT
: No point in defining this everyone - exporting and defining should be enough.For further information, see:
NB:
Please try out the branch and tell me if you see any issues on Mac. I normally run:
Which runs to completion.
This PR...
Changes
Fixes
Checklist