Fix/Cleanup Makefile - Closes kubeshop/kusk-gateway#418
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kusk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jasmingacic
previously approved these changes
May 18, 2022
kylehodgetts
suggested changes
May 18, 2022
Thanks. Yes. What particular type of tests do you have in mind? In a separate PR or this one? Actually, the reason I wanted folks to try out my branch was to be sure I hadn't broken anything. I am going to test further before we even get to merge state. |
|
If possible add consistent test even though CI should detect it |
|
A separate PR. on build before merge to master
|
|
works with go 1.18 both on MacOS and Ubuntu |
* Replace `go get` with `go install` in `Makefile`. * Tidy up `Makefile`. * Introduce `tools` in `Makefile` that downloads all the tools/dependencies required. * `DOCKER_BUILDKIT`: No point in defining this everyone - exporting and defining should be enough. For further information, see: * kubernetes-sigs/kubebuilder#2566 * kubernetes-sigs/kubebuilder#2486
1. > The indentation for these variable assignments are a bit all over the place, can you align them, please? 2. > If you've tested that kustomize v4 works as expected, this comment can be removed Closes #418
mbana
force-pushed
the
mbana-makefile-fixes
branch
from
4d8239f
to
85539c8
Compare
mbana
requested review from
kylehodgetts and
jasmingacic
and removed request for
Tarick
jasmingacic
approved these changes
May 25, 2022
kylehodgetts
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/Cleanup
Makefile- Closes #418:go getwithgo installinMakefile.Makefile.toolsinMakefilethat downloads all the tools/dependencies required.DOCKER_BUILDKIT: No point in defining this everyone - exporting and defining should be enough.For further information, see:
NB:
Please try out the branch and tell me if you see any issues on Mac. I normally run:
Which runs to completion.
This PR...
Changes
Fixes
Checklist