fix: error handling when creating TW (#5631)

* fix: error handling when creating TW * fix: remove object.name update * fix: move error to debug * fix: handle error on update
kubeshop · Jul 3, 2024 · 5f734c4 · 5f734c4
1 parent dbe6284
commit 5f734c4
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/cmd/kubectl-testkube/commands/testworkflows/create.go b/cmd/kubectl-testkube/commands/testworkflows/create.go
@@ -67,7 +67,15 @@ func NewCreateTestWorkflowCmd() *cobra.Command {
 				}
 			}
 
-			workflow, _ := client.GetTestWorkflow(obj.Name)
+			workflow, err := client.GetTestWorkflow(obj.Name)
+			if err != nil {
+				if update {
+					ui.ExitOnError("getting test workflow "+obj.Name+" in namespace "+obj.Namespace, err)
+				} else {
+					ui.Debug("getting test workflow "+obj.Name+" in namespace "+obj.Namespace, err.Error())
+				}
+			}
+
 			if workflow.Name != "" {
 				if !update {
 					ui.Failf("Test workflow with name '%s' already exists in namespace %s, use --update flag for upsert", obj.Name, namespace)