fix: error handling when creating TW #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exu
requested review from
nicufk,
vsukhin,
vLia,
povilasv and
dejanzele
as code owners
✅ Deploy Preview for testkube-docs-preview canceled.
|
vsukhin
approved these changes
Jul 3, 2024
rangoo94
requested changes
Jul 3, 2024
| @@ -67,7 +67,9 @@ func NewCreateTestWorkflowCmd() *cobra.Command { | |||
| } | |||
| } | |||
|
|
|||
| workflow, _ := client.GetTestWorkflow(obj.Name) | |||
| workflow, err := client.GetTestWorkflow(obj.Name) | |||
| ui.ExitOnError("getting test workflow "+obj.Name+" in namespace "+obj.Namespace, err) | |||
There was a problem hiding this comment.
That should not be there, as will disallow creating new TestWorkflows, unless you will replace err = nil in case of "404 Not Found" error
rangoo94
approved these changes
Jul 3, 2024
|
vsukhin
pushed a commit
that referenced
this pull request
Jul 3, 2024
* fix: error handling when creating TW * fix: remove object.name update * fix: move error to debug * fix: handle error on update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes