Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling when creating TW #5631

Merged
merged 4 commits into from
Jul 3, 2024
Merged

fix: error handling when creating TW #5631

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7bf2ca
fix: error handling when creating TW
exu Jul 3, 2024
77b6bc5
fix: remove object.name update
exu Jul 3, 2024
8240df0
fix: move error to debug
exu Jul 3, 2024
dbcb556
fix: handle error on update
exu Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/kubectl-testkube/commands/testworkflows/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ func NewCreateTestWorkflowCmd() *cobra.Command {
obj.Name = name
}

// pass name from metadata in case of updating file
if obj.Name == "" {
obj.Name = obj.GetObjectMeta().GetName()
}

client, _, err := common.GetClient(cmd)
ui.ExitOnError("getting client", err)

Expand All @@ -67,7 +72,9 @@ func NewCreateTestWorkflowCmd() *cobra.Command {
}
}

workflow, _ := client.GetTestWorkflow(obj.Name)
workflow, err := client.GetTestWorkflow(obj.Name)
ui.ExitOnError("getting test workflow "+obj.Name+" in namespace "+obj.Namespace, err)
Copy link
Member

@rangoo94 rangoo94 Jul 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be there, as will disallow creating new TestWorkflows, unless you will replace err = nil in case of "404 Not Found" error


if workflow.Name != "" {
if !update {
ui.Failf("Test workflow with name '%s' already exists in namespace %s, use --update flag for upsert", obj.Name, namespace)
Expand Down