feat(server): implement postgres queue driver #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Aug 4, 2023
Comment on lines
+8
to
+14
| type loggerFn func(string, ...any) | ||
|
|
||
| func newLoggerFn(name string) loggerFn { | ||
| return func(format string, params ...any) { | ||
| log.Printf("[%s] %s", name, fmt.Sprintf(format, params...)) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is useful even outside of this package. Perhaps we could move it to a specific infra package in the future?
There was a problem hiding this comment.
yes, I found the pattern very useful, but if we want to improve our logging I would make it a bit more sophisticated
| return | ||
| } | ||
|
|
||
| ctx, cancelCtx := context.WithTimeout(context.Background(), 500*time.Millisecond) |
There was a problem hiding this comment.
Can we add this 500ms timeout as a constant? Something like enqueueTimeout?
xoscar
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a postgres queue driver
Changes
Checklist