-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): implement postgres queue driver #3030
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f53847a
implement pg queue
schoren b5403ce
fix json encoding
schoren 8acbc3c
implement single worker/connection queue
schoren 5741d4b
remove pointless logs
schoren 5da786f
fix test
schoren f232e62
move magic number to constant
schoren 66bd1f3
update deprecated lib
schoren 4b67c9d
gracefully handle connection errors
schoren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
package executor | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
) | ||
|
||
type loggerFn func(string, ...any) | ||
|
||
func newLoggerFn(name string) loggerFn { | ||
return func(format string, params ...any) { | ||
log.Printf("[%s] %s", name, fmt.Sprintf(format, params...)) | ||
} | ||
} | ||
|
||
func NewInMemoryQueueDriver(name string) *InMemoryQueueDriver { | ||
return &InMemoryQueueDriver{ | ||
log: newLoggerFn(fmt.Sprintf("InMemoryQueueDriver - %s", name)), | ||
queue: make(chan Job), | ||
exit: make(chan bool), | ||
name: name, | ||
} | ||
} | ||
|
||
type InMemoryQueueDriver struct { | ||
log loggerFn | ||
queue chan Job | ||
exit chan bool | ||
q *Queue | ||
name string | ||
} | ||
|
||
func (qd *InMemoryQueueDriver) SetQueue(q *Queue) { | ||
qd.q = q | ||
} | ||
|
||
func (qd InMemoryQueueDriver) Enqueue(job Job) { | ||
qd.queue <- job | ||
} | ||
|
||
func (qd InMemoryQueueDriver) Start() { | ||
for i := 0; i < QueueWorkerCount; i++ { | ||
go func() { | ||
qd.log("start") | ||
for { | ||
select { | ||
case <-qd.exit: | ||
qd.log("exit") | ||
return | ||
case job := <-qd.queue: | ||
qd.q.Listen(job) | ||
} | ||
} | ||
}() | ||
} | ||
} | ||
|
||
func (qd InMemoryQueueDriver) Stop() { | ||
qd.log("stopping") | ||
qd.exit <- true | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful even outside of this package. Perhaps we could move it to a specific infra package in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I found the pattern very useful, but if we want to improve our logging I would make it a bit more sophisticated