You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I encountered a strange problem when I wrote unit test due to the version of controller-runtime.
I use code like this r.Client.List(..., &unstructured.UnstructuredList{}, ...), It run correctly when the Client is RestClient, but It'll run into error when the client is fake client in the unit test scenario.
I found the root cause is this issue, but the PR which fix this issue was merged only in the 0.9.x version of controller-runtime, I tried to update the controller-runtime v0.6.3 => v0.9.7 but It caused too many changes.
So I Added code manually like this in the unit test:
And the fluxcd project actually provide the module which include the HelmRelease type for convenience. But It also need higher version of controller-runtime.
Is it possible to update the controller-runtime version when it arrive version 1.0 or LTS ?
The text was updated successfully, but these errors were encountered:
We'd better upgrade controller-runtime at some point. We already talked about this in #353
But as you mentioned, it requires a lot of work on this. I'd like to do it once I got enough time. But please feel free to help on this if there is anyone willing to do it.
I encountered a strange problem when I wrote unit test due to the version of controller-runtime.
I use code like this
r.Client.List(..., &unstructured.UnstructuredList{}, ...)
, It run correctly when the Client is RestClient, but It'll run into error when the client is fake client in the unit test scenario.I found the root cause is this issue, but the PR which fix this issue was merged only in the 0.9.x version of controller-runtime, I tried to update the controller-runtime v0.6.3 => v0.9.7 but It caused too many changes.
So I Added code manually like this in the unit test:
And the fluxcd project actually provide the module which include the HelmRelease type for convenience. But It also need higher version of controller-runtime.
Is it possible to update the controller-runtime version when it arrive version 1.0 or LTS ?
The text was updated successfully, but these errors were encountered: