Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-runtime to v0.12.3 #788

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Aug 18, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

fix #751
fix #353

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

Upgrade controller-runtime to v0.12.3
kubespheredev/devops-apiserver:dev-v3.2.1-rc.3-082b7eb
kubespheredev/devops-controller:dev-v3.2.1-rc.3-082b7eb

@ks-ci-bot ks-ci-bot requested a review from a team August 18, 2022 04:40
@ks-ci-bot ks-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note labels Aug 18, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added needs-rebase size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 18, 2022
@LinuxSuRen LinuxSuRen force-pushed the upgrade-controller-runtime branch 3 times, most recently from 2114ce5 to c838b07 Compare August 18, 2022 09:31
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #788 (082b7eb) into master (2809686) will decrease coverage by 28.50%.
The diff coverage is 57.69%.

@@             Coverage Diff             @@
##           master     #788       +/-   ##
===========================================
- Coverage   79.49%   50.99%   -28.51%     
===========================================
  Files         172      171        -1     
  Lines       24195    10143    -14052     
===========================================
- Hits        19235     5172    -14063     
- Misses       4675     4681        +6     
- Partials      285      290        +5     
Flag Coverage Δ
unittests 50.99% <57.69%> (-28.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/controller/app/options/options.go 0.00% <ø> (ø)
controllers/addon/addon_controller.go 44.44% <ø> (+0.60%) ⬆️
controllers/addon/operator_controller.go 73.17% <ø> (+1.74%) ⬆️
...ers/argocd/argocd-application-status-controller.go 95.31% <ø> (-0.08%) ⬇️
controllers/argocd/git-repository-controller.go 94.80% <ø> (-0.07%) ⬇️
controllers/argocd/image-updater-controller.go 100.00% <ø> (ø)
controllers/argocd/multi-cluster-controller.go 95.04% <ø> (ø)
controllers/argocd/project_controller.go 68.83% <ø> (+0.88%) ⬆️
controllers/core/fake.go 100.00% <ø> (ø)
controllers/fluxcd/git-repository-controller.go 80.28% <ø> (-0.28%) ⬇️
... and 61 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LinuxSuRen LinuxSuRen merged commit 5c830fe into kubesphere:master Aug 19, 2022
@LinuxSuRen LinuxSuRen deleted the upgrade-controller-runtime branch August 19, 2022 08:07
@lxm lxm mentioned this pull request Aug 20, 2022
3 tasks
@kubesphere kubesphere deleted a comment from ks-ci-bot Nov 11, 2022
@kubesphere kubesphere deleted a comment from ks-ci-bot Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider Update the version of controller-runtime Request to upgrade dependencies in go.mod
2 participants