Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to upgrade dependencies in go.mod #353

Closed
JohnNiang opened this issue Nov 11, 2021 · 3 comments · Fixed by #788
Closed

Request to upgrade dependencies in go.mod #353

JohnNiang opened this issue Nov 11, 2021 · 3 comments · Fixed by #788
Assignees

Comments

@JohnNiang
Copy link
Member

At present, our project dependencies defined in go.mod file that are too old may not be able to run in Kubernetes 1.22 correctly, especially when we create a webhook targeting for some CRDs.

I suggest upgrading dependencies related Kubernetes, such as sigs.k8s.io/controller-runtime, k8s.io/api and so on.

There was an example for that: kubesphere/s2ioperator#163.

/kind enhancement

@ks-ci-bot
Copy link
Collaborator

@JohnNiang: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

At present, our project dependencies defined in go.mod file that are too old may not be able to run in Kubernetes 1.22 correctly, especially when we create a webhook targeting for some CRDs.

I suggest upgrading dependencies related Kubernetes, such as sigs.k8s.io/controller-runtime, k8s.io/api and so on.

There was an example for that: kubesphere/s2ioperator#163.

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lxm
Copy link
Member

lxm commented Aug 5, 2022

So, let's continue our discussion here.
I want to express whether there has been some tentative work before to help people who want to work on this PR figure out what needs to be done. @LinuxSuRen @kubesphere/sig-devops

@LinuxSuRen
Copy link
Member

This is great to do the upgrade work. Because we will have enough to do the test work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants