Skip to content

Commit

Permalink
Fix: example manager and instructions (#48)
Browse files Browse the repository at this point in the history
* Feat: upgrade k8s.io dependency to 0.26 (#39)

* Feat: upgrade k8s.io dependency to 0.26

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

* Fix: golangci-lint action failure

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

---------

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: add cluster info to action context (#43)

Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: add cronjob source (#42)

* Refactor: allow the use of singleton for one Source, while also allowing non-singleton Sources, making it more extensible

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Feat: add cronjob source

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: update cron lib

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Feat: do not exit if config contains invalid sources

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: add tests and fix linter

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: go mod tidy

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Docs: add cronjob example

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* fix comments

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: force lint to use the exact version

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* remove unnecessary dep

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* fix comments

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* use codecov token

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* update lint script

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

---------

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: support leader election for kube-trigger (#45)

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* adds instruction to enable kube-trigger addon

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* updates sample.yaml path

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* fix: updates instructions to apply config files in order

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* fix: adds the missing api group to the first rule

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: support leader election for kube-trigger (#45)"

This reverts commit 4351008.

Removing changes unrelated to this branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: add cronjob source (#42)"

This reverts commit 46f5975.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: add cluster info to action context (#43)"

This reverts commit e214be5.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: upgrade k8s.io dependency to 0.26 (#39)"

This reverts commit a22e316.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

---------

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Co-authored-by: Somefive <Somefive@foxmail.com>
Co-authored-by: yangs <yangsoonlx@gmail.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com>
  • Loading branch information
5 people authored May 19, 2023
1 parent 2a3243f commit ed3b9a6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
4 changes: 3 additions & 1 deletion config/manager/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ metadata:
creationTimestamp: null
name: kube-trigger-manager-role
rules:
- resources:
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
Expand Down
10 changes: 8 additions & 2 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ updated whenever the ConfigMaps that are referenced by `ref-objects` are updated
## Prerequisites

- Install [KubeVela](https://kubevela.net/docs/install) in your cluster
- Enable the `kube-trigger` addon
```shell
vela addon enable kube-trigger
```

## What we want to achieve?

Expand All @@ -26,7 +30,7 @@ Apply `sample.yaml` to create 2 Applications and 2 ConfigMaps in the default nam
trigger 2 Application updates.

```shell
kubectl apply sample.yaml
kubectl apply -f examples/sample.yaml
```

2. **Run kube-trigger**
Expand All @@ -43,7 +47,9 @@ Standalone:
In-Cluster:

```shell
kubectl apply -f config/
kubectl apply -f config/crd/
kubectl apply -f config/definition/
kubectl apply -f config/manager/
```

3. **Watch ApplicationRevision changes** so that you can see what it does.
Expand Down

0 comments on commit ed3b9a6

Please sign in to comment.