Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add cluster info to action context #43

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Feat: add cluster info to action context #43

merged 1 commit into from
Apr 13, 2023

Conversation

yangsoon
Copy link
Contributor

@yangsoon yangsoon commented Apr 12, 2023 •
edited
Loading

Description of your changes

  1. add cluster info to action context
  2. upgrade kubevela/pkg dependency
  3. add more logs

I have:

  • Read and followed KubeVela's contribution process.
  • Add related tests.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@yangsoon yangsoon force-pushed the feature/update-kubevela-pkg branch from c2d692e to ba6ffa8 Compare April 12, 2023 09:32
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 52.77% and project coverage change: -2.04 ⚠️

Comparison is base (6582e75) 75.23% compared to head (a667a89) 73.19%.

❗ Current head a667a89 differs from pull request most recent head 6b0c694. Consider uploading reports for the commit 6b0c694 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   75.23%   73.19%   -2.04%     
==========================================
  Files          12       13       +1     
  Lines        1078     1134      +56     
==========================================
+ Hits          811      830      +19     
- Misses        229      262      +33     
- Partials       38       42       +4
Flag Coverage Δ
unittests 73.19% <52.77%> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/filter/filter.go 33.92% <52.77%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yangsoon yangsoon force-pushed the feature/update-kubevela-pkg branch from ba6ffa8 to a667a89 Compare April 12, 2023 09:38
Feat: add cluster info in action context
6b0c694 
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
@yangsoon yangsoon force-pushed the feature/update-kubevela-pkg branch from a667a89 to 6b0c694 Compare April 13, 2023 01:58
@wonderflow wonderflow merged commit 2d521b3 into kubevela:main Apr 13, 2023
@yangsoon yangsoon deleted the feature/update-kubevela-pkg branch April 13, 2023 02:01
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
d8810f3 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
fe14961 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
6416d8a 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
f93644d 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
a0cb2c3 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
12ac349 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
bf878b2 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 11, 2023
@yangsoon @semmet95
Feat: add cluster info to action context (kubevela#43)
e214be5 
Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 added a commit to semmet95/kube-trigger that referenced this pull request May 19, 2023
@semmet95
Revert "Feat: add cluster info to action context (kubevela#43)"
730ca1f 
This reverts commit e214be5.

Removes changes unrelated to the branch
semmet95 added a commit to semmet95/kube-trigger that referenced this pull request May 19, 2023
@semmet95
Revert "Feat: add cluster info to action context (kubevela#43)"
f6a79de 
This reverts commit e214be5.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>
FogDong pushed a commit that referenced this pull request May 19, 2023
@semmet95 @Somefive
@yangsoon @charlie0129
Fix: example manager and instructions (#48)
ed3b9a6 
* Feat: upgrade k8s.io dependency to 0.26 (#39)

* Feat: upgrade k8s.io dependency to 0.26

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

* Fix: golangci-lint action failure

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>

---------

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: add cluster info to action context (#43)

Feat: add cluster info in action context

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: add cronjob source (#42)

* Refactor: allow the use of singleton for one Source, while also allowing non-singleton Sources, making it more extensible

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Feat: add cronjob source

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: update cron lib

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Feat: do not exit if config contains invalid sources

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: add tests and fix linter

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: go mod tidy

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Docs: add cronjob example

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* fix comments

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* Chore: force lint to use the exact version

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* remove unnecessary dep

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* fix comments

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* use codecov token

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* update lint script

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

---------

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Feat: support leader election for kube-trigger (#45)

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>

* adds instruction to enable kube-trigger addon

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* updates sample.yaml path

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* fix: updates instructions to apply config files in order

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* fix: adds the missing api group to the first rule

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: support leader election for kube-trigger (#45)"

This reverts commit 4351008.

Removing changes unrelated to this branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: add cronjob source (#42)"

This reverts commit 46f5975.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: add cluster info to action context (#43)"

This reverts commit e214be5.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

* Revert "Feat: upgrade k8s.io dependency to 0.26 (#39)"

This reverts commit a22e316.

Removes changes unrelated to the branch

Signed-off-by: Amit Singh <singhamitch@outlook.com>

---------

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Co-authored-by: Somefive <Somefive@foxmail.com>
Co-authored-by: yangs <yangsoonlx@gmail.com>
Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie0129 charlie0129 charlie0129 approved these changes

@Somefive Somefive Somefive approved these changes

@wonderflow wonderflow wonderflow approved these changes

@FogDong FogDong Awaiting requested review from FogDong FogDong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangsoon @wonderflow @Somefive @charlie0129