Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added #1217

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Mar 30, 2023

📝 Description

When adding a volume from existing PVC, the submit function tried to find a PVC that yet to be created, so changing it so the PVC gets selected only after being created.
also updating more possible statuses for cloning DS and creating a check to see if the DS is uploading a PVC
Also fixing list of bootable volumes to show only ready DS or DS in the upload/clone process

🎥 Demo

Before:

add-volume-stuck.mp4

After:

add-volume-stuck-after.mp4

@openshift-ci openshift-ci bot added bugzilla/severity-high bugzilla/valid-bug approved This issue is something we want to fix labels Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@avivtur: This pull request references Bugzilla bug 2177977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang March 30, 2023 09:36
@avivtur avivtur force-pushed the ready_cloning_ds branch 2 times, most recently from 4627b56 to 29bc6b3 Compare March 30, 2023 09:52
…matically just after it's been added

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@avivtur: This pull request references Bugzilla bug 2177977, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

avivtur added a commit to avivtur/kubevirt-plugin that referenced this pull request Mar 30, 2023
…ui#1217

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-merge-robot openshift-merge-robot merged commit 6539bd8 into kubevirt-ui:main Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2177977 has been moved to the MODIFIED state.

In response to this:

Bug 2177977: The volume in instanceTypes page should be selected automatically just after it's been added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants