Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2177977: Move pagination to created/selected volume from modals #1253

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 17, 2023

📝 Description

When Creating a new volume from the "Add volume" modal dialog or selecting a volume from the "Show all" modal dialog, the volume is selected but the pagination is not moving to the proper page to show the created/selected volume.

🎥 Demo

Before:

select volume:

show-all-select-volume-without-moving-pagination.mp4

create volume:

volume-selected-without-moving-pagination.mp4

After:

select volume:

show-all-select-volume-moving-pagination.mp4

create volume:

volume-selected-moving-pagination.mp4

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot requested review from pcbailey and tnisan April 17, 2023 12:39
@openshift-ci openshift-ci bot added bugzilla/severity-high bugzilla/valid-bug approved This issue is something we want to fix labels Apr 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

@avivtur: This pull request references Bugzilla bug 2177977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2177977: Move pagination to created/selected volume from modals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang April 17, 2023 12:39
Copy link

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested - both scenarios, works really nice!

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member Author

avivtur commented Apr 19, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit eafb7d9 into kubevirt-ui:main Apr 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2177977 has been moved to the MODIFIED state.

In response to this:

Bug 2177977: Move pagination to created/selected volume from modals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur
Copy link
Member Author

avivtur commented Apr 19, 2023

/cherrypick release-4.13

@openshift-cherrypick-robot
Copy link
Collaborator

@avivtur: new pull request created: #1266

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants