Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-36883: removing disk help icon #1725

Conversation

metalice
Copy link
Member

📝 Description

Removing disk title help icon

🎥 Demo

After:
image

Before:
image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 16, 2024

@metalice: This pull request references CNV-36883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Removing disk title help icon

🎥 Demo

After:
image

Before:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 16, 2024
@metalice metalice force-pushed the CNV-36883-removing-disk-help-icon branch from 8d83be7 to ff79197 Compare January 16, 2024 10:16
@pcbailey
Copy link
Member

@metalice Did you intend to push the commit that removes the IPv4 checks?

@metalice
Copy link
Member Author

@metalice Did you intend to push the commit that removes the IPv4 checks?

no I didn't. thanks! pushed

@metalice metalice force-pushed the CNV-36883-removing-disk-help-icon branch from ff79197 to 1d37ec3 Compare January 16, 2024 14:13
@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 16, 2024
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 486398d into kubevirt-ui:main Jan 16, 2024
9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants