Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-36883: removing disk help icon #1725

Merged
merged 1 commit into from
Jan 16, 2024
Merged

CNV-36883: removing disk help icon #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion locales/en/plugin__kubevirt-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,6 @@
"The following credentials for this operating system were created via cloud-init. If unsuccessful, cloud-init could be improperly configured.": "The following credentials for this operating system were created via cloud-init. If unsuccessful, cloud-init could be improperly configured.",
"The following disk will not be included in the snapshot": "The following disk will not be included in the snapshot",
"The following disk will not be included in the snapshot_plural": "The following disk will not be included in the snapshot",
"The following information is provided by the OpenShift Virtualization operator.": "The following information is provided by the OpenShift Virtualization operator.",
"The following information regarding how the disks are partitioned is provided by the guest agent.": "The following information regarding how the disks are partitioned is provided by the guest agent.",
"The following resources will be deleted along with this VirtualMachine. Unchecked items will not be deleted.": "The following resources will be deleted along with this VirtualMachine. Unchecked items will not be deleted.",
"The machine type defines the virtual hardware configuration while the operating system name and version refer to the hypervisor.": "The machine type defines the virtual hardware configuration while the operating system name and version refer to the hypervisor.",
Expand Down
13 changes: 2 additions & 11 deletions src/utils/components/DiskListTitle/DiskListTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import React from 'react';

import HelpTextIcon from '@kubevirt-utils/components/HelpTextIcon/HelpTextIcon';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { Flex, PopoverPosition, Title } from '@patternfly/react-core';
import { Title } from '@patternfly/react-core';

import SearchItem from '../SearchItem/SearchItem';

Expand All @@ -11,15 +10,7 @@ const DiskListTitle = () => {

return (
<Title headingLevel="h2">
<Flex alignItems={{ default: 'alignItemsCenter' }}>
<SearchItem id="disks">{t('Disks')}</SearchItem>
<HelpTextIcon
bodyContent={t(
'The following information is provided by the OpenShift Virtualization operator.',
)}
position={PopoverPosition.right}
/>
</Flex>
<SearchItem id="disks">{t('Disks')}</SearchItem>
</Title>
);
};
Expand Down
Loading